Loading config file fails if "media_types = mediagoblin.media_types.image" in the config

[Simon Fondrie-Teitler]

It works fine if you add a comma at the end.

backtrace:

Traceback (most recent call last):
  File "/usr/bin/paster", line 4, in <module>
    command.run()
  File "/usr/lib/python2.7/dist-packages/paste/script/command.py", line 104, in run
    invoke(command, command_name, options, args[1:])
  File "/usr/lib/python2.7/dist-packages/paste/script/command.py", line 143, in invoke
    exit_code = runner.run(args)
  File "/usr/lib/python2.7/dist-packages/paste/script/command.py", line 238, in run
    result = self.command()
  File "/usr/lib/python2.7/dist-packages/paste/script/serve.py", line 284, in command
    relative_to=base, global_conf=vars)
  File "/usr/lib/python2.7/dist-packages/paste/script/serve.py", line 321, in loadapp
    **kw)
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 247, in loadapp
    return loadobj(APP, uri, name=name, **kw)
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 272, in loadobj
    return context.create()
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 710, in create
    return self.object_type.invoke(self)
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 203, in invoke
    app = context.app_context.create()
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 710, in create
    return self.object_type.invoke(self)
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 144, in invoke
    **context.local_conf)
  File "/usr/lib/python2.7/dist-packages/paste/deploy/util.py", line 56, in fix_call
    val = callable(*args, **kw)
  File "/usr/lib/python2.7/dist-packages/paste/urlmap.py", line 25, in urlmap_factory
    app = loader.get_app(app_name, global_conf=global_conf)
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 350, in get_app
    name=name, global_conf=global_conf).create()
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 710, in create
    return self.object_type.invoke(self)
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 229, in invoke
    filtered = context.next_context.create()
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 710, in create
    return self.object_type.invoke(self)
  File "/usr/lib/python2.7/dist-packages/paste/deploy/loadwsgi.py", line 146, in invoke
    return fix_call(context.object, context.global_conf, **context.local_conf)
  File "/usr/lib/python2.7/dist-packages/paste/deploy/util.py", line 56, in fix_call
    val = callable(*args, **kw)
  File "/usr/share/mediagoblin/mediagoblin/app.py", line 254, in paste_app_factory
    mgoblin_app = MediaGoblinApp(mediagoblin_config)
  File "/usr/share/mediagoblin/mediagoblin/app.py", line 67, in __init__
    global_config, app_config = setup_global_and_app_config(config_path)
  File "/usr/share/mediagoblin/mediagoblin/init/__init__.py", line 53, in setup_global_and_app_config
    raise ImproperlyConfigured(validation_report)
mediagoblin.init.ImproperlyConfigured: There were validation problems loading this config file:
--------------------------------------------------------
mediagoblin:media_types = the value "mediagoblin.media_types.image" is of the wrong type.
Removing PID file /home/mediagoblin/mediagoblin.pid

[Simon Fondrie-Teitler]

confirmed by pythonsnake

[pythonsnake]

Replacing media_types = string_list(default=list("mediagoblin.media_types.image")) with media_types = force_list(default=list("mediagoblin.media_types.image")) in config_spec.ini should do the trick.

[Christopher Allan Webber]

Hi! I'm moving this ticket from "assigned" to in_progress per our new workflow. Please update the ticket and let us know if you're still working on this. If you are, super great! If not, we'll remove the claim and move it back to "accepted" in a couple of weeks.

Thanks!

[rodney757]

using force_list instead of string_list, comment:3, works for me

[rodney757]

This problem will be taken care of when #704 is merged as media_types will be plugins

[rodney757]

media_types are now plugins, so we no longer have this issue :)