Opened 7 years ago

Last modified 4 years ago

#673 accepted enhancement

Anonymous Commenting

Reported by: Emily O'Leary Owned by:
Priority: minor Milestone:
Component: programming Keywords: anonymous, comments, user choice
Cc: Parent Tickets:

Description

Directly related to #525 I came across the idea of allowing users to accept anonymous comments on their pages which also led me to the idea of allowing users to moderate what comments can be shown on their page (by letting them approve comments before they are shown).

This required some DB/frontend/backend changes.

My first commit so far has included the ability to comment anonymously. My next goal is the comment moderation ability per-user and then looking at how the system works as a whole and sprucing up as needed.

You can follow my progress here:

https://gitorious.org/~lotusecho/mediagoblin/lotusechos-mediagoblin/commits/Anonymous_Commenting

Subtickets

Change History (6)

comment:1 Changed 7 years ago by Emily O'Leary

Another change I plan to make is one where this user-level option can be opted-out of at the app level. So if an instance owner wants no anonymous comments, they have got it. Possibly convert it over to a plugin some how, but I'd need some direction there.

comment:2 Changed 7 years ago by Emily O'Leary

Milestone: 0.4.00.4.1
Status: newin_progress

comment:3 Changed 6 years ago by Emily O'Leary

Milestone: 0.4.1
Owner: Emily O'Leary deleted
Status: in_progressreview
Summary: Anonymous Commenting / ModerationAnonymous Commenting

Moderation seems to be the focus of some of the other contributors and hasn't been worked on yet so the anonymous comment stuff may be where this idea ends. If someone could look this over that'd be wonderful.

comment:4 Changed 6 years ago by rodney757

Owner: set to Emily O'Leary
Status: reviewin_progress

Okay, so I did a preliminary review on this. Here are my comments:

1) So there are no migrations accompanying your changes to mg/db/models.py. Take a look at mg/db/migrations.py to see what you need to do for each addition to the existing models.

2) If you could rebase to master that would be great. When doing that, in mg/edit/views.edit_account, you don't need to call .validate() on every form field. In master, this view was changed and no longer does that.

3) send_anon_comment_email is undefined in mg/user_pages/views

4) "Anonymous" in mediagoblin/user_pages/media.html template should be wrapped in {% trans %}Anonymous{% endtrans %}. It would be even better if you could put everything starting at the comment author until after the timestamp in a trans block, other languages might not say things the same as we do.

5) It looks like you never finished the send_anon_comments function.

6) What do you think about renaming wants_anon_comments to allow_anon_comments? To *me*, wants_anon_comments reads like the user posting the comment wants to be anonymous. allow_anon_comments seems to be a little clearer for what it is doing.

Thanks

comment:5 Changed 6 years ago by Emily O'Leary

Thanks! I'll take a look at those and make some changes. I made this a while back so it'll take a bit of time to go through it.

comment:6 Changed 4 years ago by Loic Dachary

Owner: Emily O'Leary deleted
Status: in_progressaccepted
Note: See TracTickets for help on using tickets.