Opened 10 years ago
Closed 10 years ago
Last modified 10 years ago
#649 closed defect (fixed)
Use form.field.data instead of request.form['field']
|Reported by:||Elrond||Owned by:||Hans Lo|
After submitting a form, our code needs to fetch the data from the form and put it to good use (update the db!).
Our current code uses:
form = EditForm(request.form) if ... and form.validate(): some_object.one_field = request.form.get('one_field') some_object_two_field = request.form['two_field']
This works mostly, but doesn't benefit from all the validation and cleanup that wtforms gives us. So this should be rewrittn to:
form = EditForm(request.form) if ... and form.validate(): some_object.one_field = form.one_field.data some_object_two_field = form.two_field.data
This can be done in small chunks on a file by file basis, or whatever fits someone wanting to work on this. No need to do all at once. Small changes are easier to review anyway.
Change History (7)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
|Status:||new → accepted|
comment:3 by , 10 years ago
comment:4 by , 10 years ago
Merged, thank you!
There are still some more forms that need to be fixed as such but this is a great start :)
comment:5 by , 10 years ago
I believe my branch now covers everything for this issue. Please review and thank you for your patience :)
comment:6 by , 10 years ago
|Status:||accepted → closed|
Thanks for also finding all the remaining bits!
I think, we can close this now.
comment:7 by , 10 years ago