Opened 6 years ago

Last modified 4 years ago

#613 accepted enhancement

Improving Media collection

Reported by: Tumulte Owned by:
Priority: major Milestone:
Component: programming Keywords: review
Cc: Parent Tickets:

Description

Summary of changes :

Basically, to idea is to replace the tedious process to add medias to collection. It's done, by putting the form where media are.

  • When you submit a media
  • When you are on a media's page.

The "add to collection" page no longer exists (yet I haven't removed anything that whould allow it to work... up to you).

TEMPLATES

  • The media_collect.html has been splitted to be used as a stand alone or as par of another form (start.html). The media's information has been removed, it's now contextual.
  • The "embeddable form" is in utils/collection_form.html
  • submit/start.html embeds the form above

VIEWS

The "add to collection" method has been put in tools/collection.py so it can be called from the "submit a media form" and from within the media page.

  • in user_pages/views.py
    • media_home : adding the collection form
    • media_collect : it calls the collection_tools method instead
  • in submit/views.py : calls the collection_tools method, passing the new media's data

I've slightly changed the behavior when you type an existing collection : it add the media to the existing collection instead of showing an error. It was mainly because I couldn't find a way to reload the media entry page without losing the filled form. Moreover, it's a smoother way to handle the error.

Here are the changes

https://github.com/MusiqueLibre/DogmaGoblin/tree/collection_improvement

Subtickets

Change History (3)

comment:2 Changed 6 years ago by Christopher Allan Webber

Status: newreview

comment:3 Changed 6 years ago by Christopher Allan Webber

Status: reviewaccepted

I gave this a quick test (though I haven't spent much time reading the code)... here's some thoughts:

  • I think putting the collections stuff on the submit page makes that submit form really long, and a bit overwhelming, so I'm not very enthusiastic about it being on the submit page.
  • The "add a collection to this while on the page" is a good idea, but I think it'll be hard to pull off without it adding extra noise to the page. One way to do this is to have a button under "collections" that says "add to collection" and when pressed exposes the interface for adding collections.
  • I think probably this should also be a plugin?
Note: See TracTickets for help on using tickets.