Improving Media collection

[Tumulte]

Summary of changes :

Basically, to idea is to replace the tedious process to add medias to collection. It's done, by putting the form where media are.

• When you submit a media
• When you are on a media's page.

The "add to collection" page no longer exists (yet I haven't removed anything that whould allow it to work... up to you).

TEMPLATES

• The media_collect.html has been splitted to be used as a stand alone or as par of another form (start.html). The media's information has been removed, it's now contextual.

• The "embeddable form" is in utils/collection_form.html

• submit/start.html embeds the form above

VIEWS

The "add to collection" method has been put in tools/collection.py so it can be called from the "submit a media form" and from within the media page.

• in user_pages/views.py
  • media_home : adding the collection form
  • media_collect : it calls the collection_tools method instead

• in submit/views.py : calls the collection_tools method, passing the new media's data

I've slightly changed the behavior when you type an existing collection : it add the media to the existing collection instead of showing an error. It was mainly because I couldn't find a way to reload the media entry page without losing the filled form. Moreover, it's a smoother way to handle the error.

Here are the changes

​https://github.com/MusiqueLibre/DogmaGoblin/tree/collection_improvement

[Tumulte]

​https://github.com/MusiqueLibre/DogmaGoblin/commit/ab44861b800f9c16765423e652ed24d7a7b54e86

​https://github.com/MusiqueLibre/DogmaGoblin/commit/8fc88b9bbf4c072aee5651596614f09a4926abe6

[Christopher Allan Webber]

I gave this a quick test (though I haven't spent much time reading the code)... here's some thoughts:

• I think putting the collections stuff on the submit page makes that submit form really long, and a bit overwhelming, so I'm not very enthusiastic about it being on the submit page.
• The "add a collection to this while on the page" is a good idea, but I think it'll be hard to pull off without it adding extra noise to the page. One way to do this is to have a button under "collections" that says "add to collection" and when pressed exposes the interface for adding collections.
• I think probably this should also be a plugin?