Opened 8 years ago

Closed 8 years ago

#601 closed enhancement (fixed)

Increase the max tag length limit

Reported by: warp Owned by: NattilyPidgin
Priority: major Milestone:
Component: programming Keywords: sprint, bitesized, review
Cc: Parent Tickets:

Description

When importing data from flickr some months ago I hit the length limit for tags in MediaGoblin, I assume this limit is still in place.

The limit should be (at least) 255 characters, as this is the limit flickr uses. It doesn't seem to be documented anywhere, but submitting a 4096 length to flickr resulted in that tag being truncated to 255 characters.

Subtickets

Change History (7)

comment:1 Changed 8 years ago by Christopher Allan Webber

Keywords: sprint biresized added

This would be a fairly easy task for a newcomer. Marking it bitesized and for the sprint!

comment:2 in reply to:  1 Changed 8 years ago by Simon Fondrie-Teitler

Keywords: bitesized added; biresized removed

Replying to cwebber:

This would be a fairly easy task for a newcomer. Marking it bitesized and for the sprint!

That says biresized. :P I'll fix it.

comment:3 Changed 8 years ago by NattilyPidgin

I would love to take this on!

My first question is, is this possibly only one line? I just changed line 35 in mediagoblin/config_spec.ini and it works on my lazyserver

...seems too simple? I guess that's what sprint means?

comment:4 Changed 8 years ago by Christopher Allan Webber

Heya... wow you're right, it's just that one line! I thought it would be much more complex, needing a migration.

comment:5 Changed 8 years ago by NattilyPidgin

comment:6 Changed 8 years ago by NattilyPidgin

Keywords: review added
Owner: set to NattilyPidgin
Status: newassigned

comment:7 Changed 8 years ago by Christopher Allan Webber

Resolution: fixed
Status: assignedclosed

Great! Merged! Thanks :)

Yeah, the only complaint I have about this: in the future, please wrap your commit messages at column 80... it makes it a lot easier to read! :)

Good work!

Note: See TracTickets for help on using tickets.