Opened 12 years ago
Closed 12 years ago
#561 closed defect (fixed)
Audio and video should use workbench instead of tempfiles
| Reported by: | Christopher Allan Webber | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.3.3 |
| Component: | programming | Keywords: | review |
| Cc: | joar | Parent Tickets: |
Description
The audio and video media types both write to temporary files instead of using the workbench... the workbench was designed for this though as a place to put files during processing that get removed when things are done.
The NamedTemporaryFile bits should be changed over to use the workbench unless there's good reason not to, and the end of these files' processing routines should call:
workbench.destroy_self()
Change History (4)
comment:1 by , 12 years ago
| Cc: | added |
|---|
comment:2 by , 12 years ago
| Milestone: | → 0.3.3 |
|---|
I propose this patch https://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin/commit/7ff008b6dc2a8d97ff879ba8ef77525d04ad0e0e
It is currently part of the 565_workbench_cleanup branch at my repo: git://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin.git. This patch is now on top of the fix for #565 but there is no reason why this could not be applied independently to #565.
It simply adds the (dir=workbench.dir) argument to the creation of all Tempfiles which seems clean enough.
This patch is part of the larger #419 issue (don't fail on large files).
comment:3 by , 12 years ago
| Keywords: | review added |
|---|
comment:4 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Looks great... merged!
Also the workbench wasn't being killed on video processing also. Closing.
Thanks for your work on this!
cc'ing joar