Opened 9 years ago

Closed 9 years ago

#561 closed defect (fixed)

Audio and video should use workbench instead of tempfiles

Reported by: Christopher Allan Webber Owned by:
Priority: major Milestone: 0.3.3
Component: programming Keywords: review
Cc: joar Parent Tickets:

Description

The audio and video media types both write to temporary files instead of using the workbench... the workbench was designed for this though as a place to put files during processing that get removed when things are done.

The NamedTemporaryFile bits should be changed over to use the workbench unless there's good reason not to, and the end of these files' processing routines should call:

workbench.destroy_self()

Subtickets

Change History (4)

comment:1 Changed 9 years ago by Christopher Allan Webber

Cc: joar added

cc'ing joar

comment:2 Changed 9 years ago by spaetz

Milestone: 0.3.3

I propose this fix by creating the tempfiles simply in the workbench directory. This will always work as the workbench is on the local filesystem.

at my repo: git://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin.git.
It simply adds the (dir=workbench.dir) argument to the creation of all Tempfiles which seems clean enough.

This patch is part of the larger #419 issue (don't fail on large files). By using tempfiles (which might be on a smallish tmpfs) we would fail processing the stuff.

Last edited 9 years ago by spaetz (previous) (diff)

comment:3 Changed 9 years ago by spaetz

Keywords: review added

comment:4 Changed 9 years ago by Christopher Allan Webber

Resolution: fixed
Status: newclosed

Looks great... merged!

Also the workbench wasn't being killed on video processing also. Closing.

Thanks for your work on this!

Note: See TracTickets for help on using tickets.