Upgrade issue from 0.9 to 0.10

[TmCTux]

during upgrade on a debian stretch up to date (I've redone all the step on a fresh buster and ended at the same place), there were an issue during configure on the following step:
./bin/python setup.py develop --upgrade

when trying to install MarkupSafe, minimum version required by egg file was minimum 0.23, thus 2.0.0a was installed, which failed.
as a workarond, egg file has been modified to force version 1.1.1 which is stable to be installed.
Configure was fine from there.

Then, upgrade failed because a previously installed plugin (mediagoblin_private) was not found anymore. After reinstallation, all was ok.
I believe documentation should precise to either deactivate plugin during upgrade, or reinstall them before proceed at a suitable step.

[Ben Sturmfels]

Hi TmCTux, regarding the ./bin/python setup.py develop --upgrade - which documentation were you following that included this command? I was hoping we'd removed that from all of our documentation.

The issue of deactivating plugins is a good point - we don't currently have a good answer for this, so I'll get back to you.

[TmCTux]

first thank you so much for answering!

*) I was following the "release note" documentation: ​https://mediagoblin.readthedocs.io/en/stable/siteadmin/relnotes.html#id2
on the second step:
./bootstrap.sh && ./configure && make

MarkupSafe installation failed and if you want to resume, it skip the step where python module dependency is check and proceed to the next step, so it will fail later on because markupsafe is not installed. So I retrieve the "./bin/python setup.py develop --upgrade" from the printed command during configure to be able to apply my workaround (modify the egg file) and resume where it stopped. So it's indeed remove from new documentation - it's still usefull though :)

One precision concerning this markupsafe issue, I think that only happens in stretch, I've gave up in buster initially because the next issue showed up so I went back to stretch.

as said, I'm only reporting this because it could help someone having the same issue and finding that a workaround exist in this ticket, I don't think it's worth mentionning it in the official doc, too deep in detail.

*) here a doc update could help indeed, I myself totally forgot that I had installed plugins so I didn't think the issue was coming from my own configuration.

[Ben Sturmfels]

Replying to TmCTux:

first thank you so much for answering!

*) I was following the "release note" documentation: ​https://mediagoblin.readthedocs.io/en/stable/siteadmin/relnotes.html#id2
on the second step:
./bootstrap.sh && ./configure && make

MarkupSafe installation failed and if you want to resume, it skip the step where python module dependency is check and proceed to the next step, so it will fail later on because markupsafe is not installed. So I retrieve the "./bin/python setup.py develop --upgrade" from the printed command during configure to be able to apply my workaround (modify the egg file) and resume where it stopped. So it's indeed remove from new documentation - it's still usefull though :)

One precision concerning this markupsafe issue, I think that only happens in stretch, I've gave up in buster initially because the next issue showed up so I went back to stretch.

as said, I'm only reporting this because it could help someone having the same issue and finding that a workaround exist in this ticket, I don't think it's worth mentionning it in the official doc, too deep in detail.

*) here a doc update could help indeed, I myself totally forgot that I had installed plugins so I didn't think the issue was coming from my own configuration.

Hi TmCTux,

Again, sorry for the delay. I've now updated the documentation to explicitly mention taking note of plugins before upgrading and re-installing them afterwards. See commit [​https://git.savannah.gnu.org/cgit/mediagoblin.git/commit/?id=93084dfe2873008c0de904d30d10f6d82e081a7f

This will be included in the documentation for the next release. Thanks for the suggestion.

Regards,
Ben

[TmCTux]

thanks a lot - both for taking care of the doc and for taking time to answer!

Replying to Ben Sturmfels:

Replying to TmCTux:

first thank you so much for answering!

*) I was following the "release note" documentation: ​https://mediagoblin.readthedocs.io/en/stable/siteadmin/relnotes.html#id2
on the second step:
./bootstrap.sh && ./configure && make

MarkupSafe installation failed and if you want to resume, it skip the step where python module dependency is check and proceed to the next step, so it will fail later on because markupsafe is not installed. So I retrieve the "./bin/python setup.py develop --upgrade" from the printed command during configure to be able to apply my workaround (modify the egg file) and resume where it stopped. So it's indeed remove from new documentation - it's still usefull though :)

One precision concerning this markupsafe issue, I think that only happens in stretch, I've gave up in buster initially because the next issue showed up so I went back to stretch.

as said, I'm only reporting this because it could help someone having the same issue and finding that a workaround exist in this ticket, I don't think it's worth mentionning it in the official doc, too deep in detail.

*) here a doc update could help indeed, I myself totally forgot that I had installed plugins so I didn't think the issue was coming from my own configuration.

Hi TmCTux,

Again, sorry for the delay. I've now updated the documentation to explicitly mention taking note of plugins before upgrading and re-installing them afterwards. See commit [​https://git.savannah.gnu.org/cgit/mediagoblin.git/commit/?id=93084dfe2873008c0de904d30d10f6d82e081a7f

This will be included in the documentation for the next release. Thanks for the suggestion.

Regards,
Ben