Opened 12 years ago

Last modified 8 years ago

#56 closed defect (FIXED)

User gallery page

Reported by: Christopher Allan Webber Owned by: Christopher Allan Webber
Priority: minor Milestone: 0.0.3
Component: programming Keywords:
Cc: Parent Tickets:


Added to our growing list of user pages should be the user gallery,
hosted at /u/{username}/gallery/

This should have a paginated list of all works done by this

See also on pagination:
` <>`_

Attachments (1)

0001-copied-user_home-for-a-user_gallery.patch (2.3 KB ) - added by Caleb Davis 12 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 by Elrond, 12 years ago

Dones't that exist in some way as /u/{user}/ already?

Should this be moved on its own /u/{user}/gallery/ thing then?

comment:2 by Christopher Allan Webber, 12 years ago

Yup, it does, and I think that the paginated stuff should actually
be on the gallery page. We'll need to use the explicit paginator
url generation route so you can pass in the \*/gallery/ url
explicitly for that but it should work.

comment:3 by Jef van Schendel, 12 years ago

What will these pages look like? As I understand it now, we'll have
two pages, a user page and a user's gallery page. The latter will
be simply all the images that belong to that account, and the
former will have only a few images as examples, together with other
user information like a bio, albums and such.

Is that about right?

comment:4 by Christopher Allan Webber, 12 years ago

That's exactly right.

by Caleb Davis, 12 years ago


comment:5 by Caleb Davis, 12 years ago

Hi all. Here's my $0.02.

.. |image0| image::

comment:6 by Christopher Allan Webber, 12 years ago

Hiya Caleb / gullydwarf,

It looks like all that's attached here currently is a template? We
should also have a modification to the user\_pages/ and
user\_pages/ Maybe you missed it while generating the
patch? Ping me on IRC if you need help doing this.

comment:7 by Caleb Davis, 12 years ago

yeah, can you tell I've never used git before? The missing commit
[\ :sub:`cfdv/mediagoblin/cfdvs-mediagoblin/commit/64511d83e4e287ba969e43400c9041ebc5d9ec35](`\ cfdv/mediagoblin/cfdvs-mediagoblin/commit/64511d83e4e287ba969e43400c9041ebc5d9ec35)

comment:8 by Christopher Allan Webber, 12 years ago

So a good start. Some thoughts, here:

-  The gallery view doesn't work after merging in the mainline
   master because Response is no longer imported. See moving things
   over to the new render\_to\_response() function
-  It would be good if there was a link to the gallery from the
   user homepage over the "first page" of that gallery.
-  The pagination on the user page doesn't make sense anymore, but
   I'm not sure what the right solution is?
   -  Keep the pagination links, but link to pages on the gallery
      (this is possible if we use paginator.get\_page\_url\_explicit()
      and pass in the particular url for the gallery, and also requires
      that we make smart adjustments to all of pagination.html, and maybe
      even object\_gallery.html and gallery.html... and though I can
      think of how to do it it's awfully hard to describe in a ticket)
   -  Just link to the gallery in case you want to see more pictures
      (this doesn't seem intuitive at this present stage)
   -  Screw it, just keep the present pagination (this doesn't seem
      sensible either)

I mean, eventually there won't be pagination on the user homepage
because the images that appear there will be "ajaxy" with a link to
the gallery for actual pagination, but we aren't there.

So here's what I think. Caleb, can you do `#1 </issues/1>`_ and #2
and pass back to me? If people have commentary on `#3 </issues/3>`_
I'm happy to hear it. Otherwise I'll implement option 3.1.

comment:9 by Caleb Davis, 12 years ago

Okay, thanks. I switched over to render\_to\_response() with my
latest commit. I'm still trying to figure out pagination for #2

comment:10 by Caleb Davis, 12 years ago

okay, and I added the link to the gallery from the user homepage. I
placed it next to the '(logout)' link. Hopefully that does it for
`#1 </issues/1>`_ and #2.
[\ :sub:`cfdv/mediagoblin/cfdvs-mediagoblin/commit/d0b8aafdaa1b5bc6eea54bd355b9a2adeef99982](`\ cfdv/mediagoblin/cfdvs-mediagoblin/commit/d0b8aafdaa1b5bc6eea54bd355b9a2adeef99982)

comment:11 by Caleb Davis, 12 years ago

now there is no link back to the user's home page from the gallery.
I'm thinking the header\_top\_right would go '{user}'s account home
gallery (logout)', with appropriate links and bold white type for
navigation and 'you are here', respectively.

comment:12 by Elrond, 12 years ago

Component: Programming
Owner: set to Caleb Davis

comment:12 by Caleb Davis, 12 years ago

I added a link back to the user page. I don't know if I can do
anything more on this until we make some navigation decisions.

Here's my `#330 </issues/330>`_ branch -
[\ :sub:`cfdv/mediagoblin/cfdvs-mediagoblin/commits/is330](`\ cfdv/mediagoblin/cfdvs-mediagoblin/commits/is330)

comment:13 by Christopher Allan Webber, 12 years ago

Sounds great. I'll look soon, hopefully tonight!

comment:14 by Christopher Allan Webber, 12 years ago

Merged. I should be able to handle the rest of this soonish.

comment:15 by Elrond, 12 years ago

Owner: changed from Caleb Davis to Christopher Webber

comment:15 by Caleb Davis, 12 years ago

I fixed some whitespace issues that were annoying me. No functional
changes -
[\ :sub:`cfdv/mediagoblin/cfdvs-mediagoblin/commit/e8fda91bc2326911ea9a0197e595bc333540c282](`\ cfdv/mediagoblin/cfdvs-mediagoblin/commit/e8fda91bc2326911ea9a0197e595bc333540c282)

comment:16 by Christopher Allan Webber, 12 years ago

Thanks Caleb, I merged that whitespace change.

comment:17 by Elrond, 12 years ago

Milestone: 0.0.3
As discussed on irc, setting to 0.0.3.
Chris wants to handle the remaining stuff.

comment:18 by Christopher Allan Webber, 12 years ago

Status: NewClosed
I handled the remaining stuff. ;)

The pagination is there still but it points to the user's gallery

comment:19 by Will Kahn-Greene, 11 years ago

The original url for this bug was .

Note: See TracTickets for help on using tickets.