Opened 5 years ago
Closed 4 years ago
#5594 closed defect (fixed)
Remove audio spectrograms (cleanup now unused code)
Reported by: | Ben Sturmfels | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 0.11.0 |
Component: | programming | Keywords: | |
Cc: | Fernando Gutierrez | Parent Tickets: |
Description (last modified by )
Audio spectrograms don't work with Python 3 due due to a Python 2-only depedency on audiolab. The Python 2 code us unfortunately rather fragile though, which often results in bad experiences for people setting up MediaGoblin as well as bug reports.
Given we'll soon be switching to Python 3-only, I propose we drop audio spectrograms entirely. This will result in a less attractive but more reliable system.
See also #5457 for background.
Change History (4)
comment:1 by , 5 years ago
Description: | modified (diff) |
---|
comment:2 by , 5 years ago
Milestone: | 0.10.0 → 0.11.0 |
---|
comment:3 by , 5 years ago
Summary: | Remove audio spectrograms → Remove audio spectrograms (cleanup now unused code) |
---|
comment:4 by , 4 years ago
Cc: | added |
---|---|
Resolution: | → fixed |
Status: | new → closed |
The Python 2-only spectrogram code and libraries have now been removed thanks to Fernando in #5610. Yay!
I've now disabled spectrograms for Python 2 in 4f3f70d1. This change only disables spectrograms and updates install docs and Dockerfiles. We still need to strip out all the spectrogram code and extlib/freesound/.
Moving this to 0.11.0 so we don't forget to do that cleanup work.