Opened 5 years ago
Closed 4 years ago
#5575 closed defect (fixed)
Upgrade setuptools and pip in Makefile
| Reported by: | anongoblin | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | programming | Keywords: | |
| Cc: | michael@… | Parent Tickets: |
Description
[This is Michael Lynch (mtlynch.io). Boris suggested I post here under the anon account as new registrations on the issue tracker seem to be down]
When I try to install MediaGoblin on a clean machine (or in a fresh Docker container), I get an error on the "make" step because setuptools is too old in virtualenv:
https://travis-ci.org/mtlynch/mediagoblin-docker/builds/453296179
Upgrading pip and setuptools within the virtualenv solves this issue:
https://travis-ci.org/mtlynch/mediagoblin-docker/builds/453299609
I created a patch to fix this issue in the "upgrade-packages" branch of my Github fork:
https://github.com/mtlynch/mediagoblin/tree/upgrade-packages
Note:
See TracTickets
for help on using tickets.
Thanks for this Michael. It looks like you have some interesting stuff in your mediagoblin-docker repo, which I'll have to take a look at! By the way, it looks like registration is now open on issues.mediagoblin.org, so please do create an account when you get a moment.
Regarding upgrading pip and setuptools, I see that your install failed when pip installing PasteScript 2.0.2 on Debian Stretch. After running "source bin/activate && pip install --upgrade pip setuptools" in the Makefile this fixed that issue for you.
I'm a little hesitant about making everyone upgrade pip and setuptools from the internet when this may be specific to this operating system/version. For example, the issue doesn't show up in my testing on Debian Buster. I personally tend to prefer sticking with the installation tools that come with the distribution as I feel like the results are more predictable, so I'm tending to err on the side of not forcing an upgrade here, but rather to help you fix your specific error on Debian Stretch. What are your thoughts?
As to your specific case, I suspect that running the following in your Dockerfile might do the trick:
make
./bin/pip install --upgrade pip setuptools
make
There is room to improve the installation process too I think. Many, if not all, of the packages that MediaGoblin used to have to get from PyPI are now included in Debian, in Buster at least.