Opened 19 months ago

Last modified 13 months ago

#5568 review enhancement

LDAP Plguin doesn't work well with Active Directory

Reported by: Meaulnes Owned by:
Priority: minor Milestone:
Component: programming Keywords: LDAP
Cc: Parent Tickets:

Description

All,

In implementing GMG in our Active Directory Environment, I discovered that it doesn't work particularly well with AD. I've generated a patch for some changes that I've made. Some of the changes are specific to AD, but some of them should be more generic for any LDAP implementation. I've also attempted to clarify the documentation, since I had to do to quite a bit of code reading to even find what all of the LDAP config options were.

The changes in this patch are tested against my AD environment, and are known to be working -- I'll probably be rolling this out to production this week. I do hope to get an OpenLDAP implementation set up so that I can also test against it, but in reality I am probably quite a ways from it.

I wasn't able to find a style guide, so I hope that my code is up to snuff. It is my first ever patch of this sort, so please be gentle. I'm happy to answer any questions.

Subtickets

Attachments (3)

0001-Fix-LDAP-for-Active-Directory.patch (14.2 KB) - added by Meaulnes 19 months ago.
LDAP Active Directory patch
0001-Fix-LDAP-For-Active-Directory_code.patch (7.0 KB) - added by Meaulnes 19 months ago.
LDAP Active Directory patch - code changes
0001-Fix-LDAP-For-Active-Directory_docs.patch (9.5 KB) - added by Meaulnes 19 months ago.
LDAP Active Directory patch - doc changes

Download all attachments as: .zip

Change History (6)

Changed 19 months ago by Meaulnes

LDAP Active Directory patch

comment:1 Changed 19 months ago by Meaulnes

It looks like this patch does not apply cleanly against master -- it was created against stable. The README.rst fails. I'll clean it up and resubmit.

Changed 19 months ago by Meaulnes

LDAP Active Directory patch - code changes

Changed 19 months ago by Meaulnes

LDAP Active Directory patch - doc changes

comment:2 Changed 19 months ago by Meaulnes

I've uploaded 2 new patch files that reflect my changes in relation to master (rather than stable). I would have deleted the old patch file, but I can't seem to figure out how to do it. So here is what the 3 files attached to the issue are:

  • 0001-Fix-LDAP-for-Active-Directory.patch: This should be ignored / deleted. It is the original patch that diff'd against stable rather than master.
  • 0001-Fix-LDAP-For-Active-Directory_code.patch: This file is the code changes between my branch and master.
  • 0001-Fix-LDAP-For-Active-Directory_docs.patch: This file is the documentation changes between my branch and master.

Please let me know if you have any questions.

comment:3 Changed 13 months ago by ShawnRisk

Status: newreview
Note: See TracTickets for help on using tickets.