Opened 8 years ago

Closed 8 years ago

#554 closed enhancement (fixed)

Meddleware improvments & consider merging my trim_whitespace meddleware plugin

Reported by: spaetz Owned by: spaetz
Priority: major Milestone: 0.3.2
Component: programming Keywords:
Cc: Parent Tickets:

Description

1) Our Meddleware contains a NoOp Meddleware. This seems rather superfluous
2) Our ENABLED_MEDDLEWARE is stored in a tuple rather than a list, so it is not

modifiable.

3) trim_whitespace meddleware plugin

Our HTML output is very verbose (=whitespacy) as our templates are
written with an 80 char limit and lots of newlines between blocks,
variables etc....


This is a plugin that naively strips of all but the first whitespace
from the HTML response. We might want to have an all-fancy html tidy
interface here at some point, but it nicely decreases the HTML size
about a third on some simple pages.

The formerge/trim_whitespace_plugin branch on git://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin.git addresses these 3 issues in 3 patches.
It would be nice to merge at least no 2 (make ENABLED_MEDDLEWARES modifiable) for this release, so my plugin works and can be distributed separatedly).

What is our policy with regard to plugins? Ship some bundled? Or should I provide them separately?

Subtickets

Change History (2)

comment:1 Changed 8 years ago by Elrond

Milestone: 0.3.30.3.2
Owner: set to spaetz
Status: newassigned

Okay, I think, this one was merged too. See 99454686 and its ancestors.

Can someone please confirm?

comment:2 Changed 8 years ago by spaetz

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.