Opened 2 years ago

Last modified 13 months ago

#5512 review defect

Disable Mozilla Persona plugin

Reported by: ayleph Owned by:
Priority: trivial Milestone:
Component: programming Keywords: persona, plugin
Cc: Parent Tickets:

Description

Mozilla Persona has been decommissioned. We should disable or remove the built-in Persona plugin. I like the idea of disabling it but leaving it there, so we have more examples of plugins. But I'd also be okay with just removing it altogether.

Here's something I had in mind for disabling the plugin.

diff --git a/mediagoblin/plugins/persona/__init__.py b/mediagoblin/plugins/persona/__init__.py
index 8fab726ae..2b8928c6b 100644
--- a/mediagoblin/plugins/persona/__init__.py
+++ b/mediagoblin/plugins/persona/__init__.py
@@ -25,10 +25,21 @@ from mediagoblin.tools import pluginapi
 from mediagoblin.tools.staticdirect import PluginStatic
 from mediagoblin.tools.translate import pass_to_ugettext as _
 
+from mediagoblin.init import ImproperlyConfigured
+
 PLUGIN_DIR = os.path.dirname(__file__)
 
 
 def setup_plugin():
+    """
+    Mozilla Persona has been decommissioned. This plugin exists for 
+    historical reasons and serves as an example of an authentication 
+    plugin.
+    """
+    raise ImproperlyConfigured(
+        _('Mozilla Persona has been decommissioned. MediaGoblin cannot '
+          'be started with the Persona plugin enabled.'))
+
     config = pluginapi.get_config('mediagoblin.plugins.persona')
 
     routes = [

Subtickets

Change History (1)

comment:1 Changed 13 months ago by ShawnRisk

Status: newreview

This should be made into a patch.

Note: See TracTickets for help on using tickets.