#5476 closed defect (fixed)

Extra whitespace around OAuth verifier code in HTML

Reported by: Ben Sturmfels Owned by:
Priority: minor Milestone:
Component: graphic design/interface Keywords: small
Cc: Parent Tickets:

Description

I start up Pumpa with a fresh config file and point it at my local MediaGoblin:

pumpa -c temp.cfg

Then I enter my account ben@localhost:6543 and wait 5 mins for Pumpa to try HTTPS, fail, and then try HTTP. When it does, the MediaGoblin asks you to log in, then pops up the OAuth page. Once you click "verify" it shows the OAuth verifier code. All good so far.

Problem is, there's an invisible space at the end of the verifier code which, if accidentally copied too, will make the OAuth verification fail (Pumpa just shows a blank screen).

When you repeat the process from the start without copying the space, the verification succeeds and you see the feed of media items.

This space should be removed by removing the spaces/line breaks around the verifier code in the HTML template.

Subtickets

Attachments (1)

issue_5476.patch (1.0 KB) - added by Vijeth 16 months ago.
Removed line breaks or spaces around the verifier code.

Download all attachments as: .zip

Change History (3)

Changed 16 months ago by Vijeth

Attachment: issue_5476.patch added

Removed line breaks or spaces around the verifier code.

comment:1 Changed 16 months ago by Vijeth

Status: newreview

Hi,

I have successfully reproduced the bug, and modified the HTML template so that the extra space is removed. I have also verified it twice.

This was an easy fix, hoping to contribute more. Waiting for a review.

Thanks,
Newcomer to MediaGlobin,
Vijeth

comment:2 Changed 16 months ago by Boris Bobrov

Resolution: fixed
Status: reviewclosed

Thank you, merged!

Note: See TracTickets for help on using tickets.