Comment box needs some top padding/margin

[Ben Sturmfels]

When you click "add comment", there's no vertical space between the "Silence comments" button and the "Comment" label. It needs a little so that it doesn't look to cramped. See attached pic.

[Ben Sturmfels]

Screenshot showing cramped layout

[jscn]

Form field input with breathing space

[jscn]

​https://github.com/jscn/mediagoblin/tree/form-field-input-padding-5468

Removed 4px margin on form field inputs and added 10px padding above and below the input. I couldn't make out any consistent padding values so just went with a value that looked reasonable.

[Boris Bobrov]

Does this bug exist on other mediagoblin themes, for example sandyseventiesspeedboat or airy?

Also, please post the patch as a .patch file? You can do it with git checkout form-field-input-padding-5468; git format-patch master

[jscn]

Patch file attached.

Checked against sandyseventiesspeedboat and airy themes: both look okay to me with the change (without the change, airy exhibits the same problem as described.)

[Ben Sturmfels]

Josh,

Thanks very much for spending time hacking MediaGoblin with us at PyConAU! Was wonderful to hang out with you!

The above changes look pretty good to me, and hopefully Boris will be able to take a look again soon and merge them in.

Cheers,
Ben

[Boris Bobrov]

Thank you! Fixed in 30812a1

[jscn]

@Sturm Thanks for organising it, it was great to see you again!

@breton Thanks!