Opened 5 years ago

Closed 5 years ago

#5387 closed defect (fixed)

[PATCH]Use six.itervalues() in delete_media_files

Reported by: 宋文武 Owned by:
Priority: major Milestone: 0.9.0
Component: programming Keywords:
Cc: Parent Tickets: #5017

Description

So I can delete media files when running with python3 :-)

Subtickets

Attachments (1)

0001-Use-six.itervalues-in-delete_media_files.patch (1.0 KB) - added by 宋文武 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by Loic Dachary

does runtests.sh pass with python3 ?

comment:2 Changed 5 years ago by Loic Dachary

There is significant work to be done before python3 actuall works ;-)

platform linux -- Python 3.4.2, pytest-2.8.5, py-1.4.31, pluggy-0.3.1
rootdir: /home/mediagoblin/software/mediagoblin/mediagoblin/mediagoblin/tests, inifile: pytest.ini
plugins: xdist-1.13.1, cov-2.2.0
collected 126 items / 2 errors / 4 skipped

mediagoblin/tests/test_api.py EEEEEEEEEEEEEEEEEEEE
mediagoblin/tests/test_auth.py EE.
mediagoblin/tests/test_basic_auth.py ..E
mediagoblin/tests/test_celery_setup.py .
mediagoblin/tests/test_collections.py E
mediagoblin/tests/test_config.py ..
mediagoblin/tests/test_csrf_middleware.py EEE
mediagoblin/tests/test_edit.py EEEE
mediagoblin/tests/test_globals.py .
mediagoblin/tests/test_legacy_api.py EE
mediagoblin/tests/test_messages.py E
mediagoblin/tests/test_metadata.py E
mediagoblin/tests/test_misc.py EEEE
mediagoblin/tests/test_modelmethods.py EEEEEEEEEEEEE
mediagoblin/tests/test_moderation.py EEEE
mediagoblin/tests/test_notifications.py EEE
mediagoblin/tests/test_oauth1.py EEEE
mediagoblin/tests/test_pdf.py s
mediagoblin/tests/test_persona.py F
mediagoblin/tests/test_piwigo.py E
mediagoblin/tests/test_pluginapi.py ...........
mediagoblin/tests/test_privileges.py EE
mediagoblin/tests/test_processing.py ..
mediagoblin/tests/test_reporting.py EEE
mediagoblin/tests/test_response.py ....
mediagoblin/tests/test_session.py .
mediagoblin/tests/test_sql_migrations.py s
mediagoblin/tests/test_staticdirect.py .
mediagoblin/tests/test_storage.py .....FF...F..
mediagoblin/tests/test_tags.py E
mediagoblin/tests/test_timesince.py .
mediagoblin/tests/test_util.py ........
mediagoblin/tests/test_workbench.py ...FE.

comment:3 Changed 5 years ago by Loic Dachary

Status: newaccepted

It passes python2 tests which includes coverage for the modified lines.

runtests.sh --cov-report=term-missing --cov=mediagoblin mediagoblin/tests
...
mediagoblin/tools/files.py 16 0 100%

Reviewed-by: Loic Dachary <loic@…>

comment:4 Changed 5 years ago by ayleph

Milestone: 0.9.0
Parent Tickets: 5017

comment:5 Changed 5 years ago by ShawnRisk

Status: acceptedreview

comment:6 Changed 5 years ago by Christopher Allan Webber

Resolution: fixed
Status: reviewclosed

Great, merged, thanks iyzsong, and thanks Loic for reviewing!

Note: See TracTickets for help on using tickets.