Opened 7 years ago
Closed 7 years ago
#5375 closed defect (fixed)
Video thumbnailer relies on function that has been removed from recent PIL
|Reported by:||ayleph||Owned by:|
|Component:||programming||Keywords:||video, thumbnail, PIL, pillow|
|Cc:||Boris Bobrov||Parent Tickets:|
A few users have come into IRC to report that their installations fail to process videos with the following error.
File '/srv/mediagoblin.example.org/mediagoblin/mediagoblin/media_types/video/processing.py', line 396 in process self.generate_thumb(thumb_size=thumb_size) File '/srv/mediagoblin.example.org/mediagoblin/mediagoblin/media_types/video/processing.py', line 319 in generate_thumb thumb_size) File '/srv/mediagoblin.example.org/mediagoblin/mediagoblin/media_types/video/transcoders.py', line 136 in capture_thumb buffer.extract_dup(0, buffer.get_size())) File '/usr/lib/python2.7/dist-packages/PIL/Image.py', line 2053 in fromstring "Please call frombytes() instead.") Exception: fromstring() has been removed. Please call frombytes() instead.
Change History (3)
comment:1 by , 7 years ago
|Status:||new → review|
comment:2 by , 7 years ago
Great! Applied to stable and master and pushed. Thank you very much.
comment:3 by , 7 years ago
|Priority:||major → critical|
|Status:||review → closed|
Note: See TracTickets for help on using tickets.
The change below appears to address this issue. It works on my instance using Pillow==2.5.3 (old), Pillow==2.7.0 (recent), and Pillow==3.0.0 (current as of this post), so I think it's safe to apply. Without the change below, video files fail to process with Pillow=3.0.0 with the same error described in this issue.
CCing breton and requesting review.