Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5372 closed defect (fixed)

test_comment_notification fails with werkzeug 0.11 or newer

Reported by: Jessica Tallon Owned by:
Priority: major Milestone: 0.9.0
Component: programming Keywords: tests, notifications, werkzeug
Cc: Christopher Allan Webber Parent Tickets:

Description

It seems any Werkzeug version 0.11 or higher breaks out test_comment_notification test, it seems the port number is dropped from the URL in the email body:

I've converted the "\n" to newlines to make it more readable.

Werkzeug 0.10.4 or below:

Hi otherperson,
chris commented on your post (http://localhost:80/u/otherperson/m/some-title/c/1/#comment) at GNU MediaGoblin

Test comment #42

GNU MediaGoblin

Werkzeug 0.11.0 and above:

Hi otherperson,
chris commented on your post (http://localhost/u/otherperson/m/some-title/c/1/#comment) at GNU MediaGoblin

Test comment #42

GNU MediaGoblin

We could just change it to have the port number in the test and it would pass however that means pinning werkzeug at 0.11 or higher, this may or may not be a problem I don't know, we already pin it at 0.7.0 or higher.

Subtickets

Change History (2)

comment:1 Changed 5 years ago by Christopher Allan Webber

Resolution: fixed
Status: newclosed

Thanks for reporting this, Jessica! I pushed a fix.

comment:2 Changed 5 years ago by Christopher Allan Webber

Milestone: 0.8.20.9.0

All 0.8.2 tickets are being rolled over to 0.9.0

Note: See TracTickets for help on using tickets.