Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5366 closed defect (fixed)

Update blog views for database changes

Reported by: ayleph Owned by:
Priority: blocker Milestone: 0.9.0
Component: programming Keywords: blog, db, migrations
Cc: tsyesika Parent Tickets:

Description

Blog views crash with server errors as they haven't been updated for the latest database changes. I've got local fixes that I'll compile and upload as a patch.

Subtickets

Attachments (1)

0001-Fix-issue-5366-Update-blog-views.patch (8.2 KB) - added by ayleph 5 years ago.
Fix for issue 5366

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by ayleph

Status: newin_progress

Claiming ticket.

Changed 5 years ago by ayleph

Fix for issue 5366

comment:2 Changed 5 years ago by ayleph

Owner: ayleph deleted
Status: in_progressreview

Patch attached in previous comment. Marking ticket for review.

comment:3 Changed 5 years ago by Loic Dachary

Owner: set to ayleph
Status: reviewin_progress

There is no existing test for the corresponding code change.

./runtests.sh --cov-report=term-missing --cov=mediagoblin mediagoblin/tests
...
mediagoblin/media_types/blog/views.py 173 173 0% 17-370
...

comment:4 Changed 5 years ago by ayleph

Owner: ayleph deleted
Status: in_progressreview

The patch provided here fixes the server crash issue. I won't be providing tests, so someone else will need to take that on if they want to do that.

comment:5 Changed 5 years ago by Jessica Tallon

Resolution: fixed
Status: reviewclosed

I have reviewed this patch and merged it into master as of beb5a4a. Thanks for reporting this and providing a patch!

comment:6 Changed 5 years ago by Christopher Allan Webber

Milestone: 0.8.20.9.0

All 0.8.2 tickets are being rolled over to 0.9.0

Note: See TracTickets for help on using tickets.