Opened 9 years ago
Closed 9 years ago
#5323 closed defect (fixed)
Audio submission failing
Reported by: | Christopher Allan Webber | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 0.9.0 |
Component: | programming | Keywords: | |
Cc: | Boris Bobrov | Parent Tickets: |
Description
Audio submission tests are failing right now in master. Right now this looks like:
mediagoblin/tests/test_submission.py ................ >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> traceback >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Traceback (most recent call last): File "/home/cwebber/devel/mediagoblin/mediagoblin/tests/test_submission.py", line 377, in test_audio self.check_normal_upload('Audio', path) File "/home/cwebber/devel/mediagoblin/mediagoblin/tests/test_submission.py", line 121, in check_normal_upload **self.upload_data(filename)) File "/home/cwebber/devel/mediagoblin/mediagoblin/tests/test_submission.py", line 92, in do_post response.follow() File "/home/cwebber/devel/mediagoblin/local/lib/python2.7/site-packages/WebTest-1.4.3-py2.7.egg/webtest/app.py", line 159, in follow % self.status) AssertionError: You can only follow redirect responses (not 200 OK)
However this error is misleading, looking at the response that is gotten back, the submission form has the error
<p class="form_field_error">Sorry, I don't support that file type :(</p>
The real problem is when submitting the procedurally generated audio, which fails to be sniffed for the audio type. In the discover() method in mediagoblin/media_types/tools.py when the last line runs, an exception is thrown:
> /home/cwebber/devel/mediagoblin/mediagoblin/media_types/tools.py(43)discover() -> discoverer = GstPbutils.Discoverer.new(60 * Gst.SECOND) (Pdb) n > /home/cwebber/devel/mediagoblin/mediagoblin/media_types/tools.py(44)discover() -> return discoverer.discover_uri(uri) (Pdb) discoverer.discover_uri(uri) *** Error: gst-stream-error-quark: No valid frames decoded before end of stream (7) (Pdb)
So that's where the error is occurring.
I wonder if maybe the procedurally generated audio is less than a second, and that's causing the error? Or it could be something else...
Change History (3)
comment:1 by , 9 years ago
Priority: | blocker → major |
---|
comment:2 by , 9 years ago
Milestone: | 0.8.0 → 0.9.0 |
---|
comment:3 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
As of today, tests are passing on master. Whatever the problem was, it has been resolved.
It looks like this one is probably not our doing, but a library issue:
As such, we can probably move forward with the release.