Opened 10 years ago
Closed 10 years ago
#5050 closed enhancement (wontfix)
Move paste.ini to paste.example.ini
Reported by: | ayleph | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 0.8.0 |
Component: | infrastructure | Keywords: | paste, make, gitignore |
Cc: | Parent Tickets: |
Description
For consistency, I'd like to see paste.ini
follow the same route as mediagoblin.ini
. That is, I'd like GMG to make a version-controlled paste.example.ini
that gets cp --no-clobber
ed to paste.ini
in Makefile.in
. Once this has been done, paste.ini should be added to .gitignore
.
--- a/.gitignore +++ b/.gitignore @@ -28,6 +28,7 @@ *.egg/ /env /mediagoblin.ini +/paste.ini /node_modules/ --- a/Makefile.in +++ b/Makefile.in @@ -101,12 +101,16 @@ endif extlib: ./devtools/update_extlib.sh -develop: $(maybe_venv_dep) i18n mediagoblin.ini +develop: $(maybe_venv_dep) i18n mediagoblin.ini paste.ini # NEVER clobber a user's mediagoblin.ini once they've defined it mediagoblin.ini: cp --no-clobber mediagoblin.example.ini mediagoblin.ini -# base-configs: paste.ini mediagoblin.example.ini +# NEVER clobber a user's paste.ini once they've defined it +paste.ini: + cp --no-clobber paste.example.ini paste.ini + +# base-configs: paste.example.ini mediagoblin.example.ini
Attachments (2)
Change History (8)
comment:1 by , 10 years ago
Milestone: | → 0.8.0 |
---|
comment:2 by , 10 years ago
Priority: | major → minor |
---|
comment:3 by , 10 years ago
Owner: | set to |
---|---|
Status: | new → in_progress |
Assigning to myself. Will submit git format patch for review.
comment:4 by , 10 years ago
Owner: | removed |
---|---|
Status: | in_progress → review |
Patch attached in git format-patch
format.
by , 10 years ago
Attachment: | 0001-move-paste.ini-to-paste.example.ini.2.patch added |
---|
by , 10 years ago
Attachment: | 0001-move-paste.ini-to-paste.example.ini.patch added |
---|
comment:5 by , 10 years ago
Ignore 0001-move-paste.ini-to-paste.example.ini.2.patch
. I had a typo in the original patch file, and when I uploaded the correct version, I forgot to check the "replace original" box.
comment:6 by , 10 years ago
Resolution: | → wontfix |
---|---|
Status: | review → closed |
I've thought about this a lot. I'd really like to merge this, and I agree the consistency is great. Here's why I'm hesitant:
- If we do this, any time we change paste.example.ini for some important reason, peoples' paste.ini won't be updated
- this isn't as big of a deal with mediagoblin.ini, because of the defaults system we have in place with the config_spec.ini stuff. We can change common things, and
- few people understand what paste.ini does, or how to modify it
- we might be rid of the whole paste deploy stuff soon anyway, since I don't think it's on python 3 yet.
... thus I'm afraid if we start having people have their own copy of paste.ini, things will break if we shift things around and it won't be obvious to users.
As such I'm marking this one as wontfix
for now, even though in some ways I agree with it and would like it to happen myself. I think there's no resolving the above, though, and people can always have a paste_local.ini if they know what they're doing.
Might as well attach this to 0.8.0.