Opened 10 years ago

Closed 22 months ago

#503 closed enhancement (no-action)

Write tests for the OAuth plugin

Reported by: joar Owned by:
Priority: major Milestone:
Component: programming Keywords: test
Cc: Parent Tickets:

Description

Add test coverage for

  • Client registration
  • Client authorization
  • Token endpoint

Subtickets

Change History (11)

comment:1 Changed 10 years ago by Christopher Allan Webber

Milestone: 0.3.2 → 0.3.3

We'd like this but it can be postponed for 0.3.3

I also think nyergler was looking into some of this but ran into problems because it's not possible presently to instantiate an app with a different config in the current codebase for tests?

comment:2 Changed 10 years ago by Christopher Allan Webber

Milestone: 0.3.3 → 0.3.4

comment:3 Changed 10 years ago by Christopher Allan Webber

Owner: changed from joar to nyergler
Status: new → assigned

IIRC nyergler is working on this.

Nathan, do you want to join us this weekend and sprint on this? Otherwise, maybe an update to where things are? (Actually, iirc you may be sprinting at pycon :))

comment:4 Changed 10 years ago by Christopher Allan Webber

Status: assigned → in_progress

Hi! I'm moving this ticket from "assigned" to in_progress per our new workflow. Please update the ticket and let us know if you're still working on this. If you are, super great! If not, we'll remove the claim and move it back to "accepted" in a couple of weeks.

Thanks!

comment:5 Changed 10 years ago by Christopher Allan Webber

Milestone: 0.4.0 → 0.4.1

Moving to 0.4.1

comment:6 Changed 10 years ago by rodney757

Owner: nyergler deleted
Status: in_progress → accepted

I'm going to assume that nyergler is no longer working on this. If you are, feel free to reclaim this.

comment:7 Changed 9 years ago by Christopher Allan Webber

Milestone: 0.5.0 → 0.6.0

comment:8 Changed 9 years ago by Christopher Allan Webber

Milestone: 0.6.0 → 0.7.0

comment:9 Changed 9 years ago by ShawnRisk

Keywords: test added

comment:10 Changed 9 years ago by Christopher Allan Webber

Milestone: 0.7.0

comment:11 Changed 22 months ago by Ben Sturmfels

Resolution: → no-action-required
Status: accepted → closed

My feeling is that one should write tests at the time the original code is written, or otherwise the next time you have to make any non-trivial change to that code (eg. fixing a bug). Writing tests for the sake of it is a pretty low-value activity. I don't think there's any use in having tickets like "write tests for blah".

Note: See TracTickets for help on using tickets.