Opened 7 years ago

Last modified 5 years ago

#499 accepted enhancement

the avatar image is necessary

Reported by: Charlie Vegan Owned by:
Priority: minor Milestone:
Component: programming Keywords: avatar
Cc: Parent Tickets:

Description

need an option to upload an avatar, I think something elemental.

Subtickets

Change History (15)

comment:1 Changed 7 years ago by spaetz

https://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin/commits/WIP/499_avatars

has now an implementation allowing a user to upload their own avatar image. The only caveat is that there is no content and image size sanity checking. This should be implemented as part of the form field validation step using PIL.

comment:2 Changed 7 years ago by spaetz

Milestone: 0.3.3

comment:3 Changed 7 years ago by spaetz

Modified above patches slightly after Elrond's review, now in branch formerge/499_avatars
Updated, the branch to current master. Elrond had this one reviewed once. Is it OK for merging?

Last edited 7 years ago by spaetz (previous) (diff)

comment:4 Changed 7 years ago by Elrond

Component: infrastructureprogramming

comment:5 Changed 7 years ago by spaetz

Keywords: review added

comment:6 Changed 7 years ago by Christopher Allan Webber

Keywords: review removed
Owner: set to spaetz
Status: newassigned

This looks good for what's there. However, I tend to wonder if we don't need the ability to have the avatar resized? I think it's maybe a bad thing to allow anyone to set any sized avatar... someone could upload really absurdly large and it would result in a not really great experience IMO.

I think we should have a task pushed out to celery to resize the avatar before it's added and committed.

Removing the review keyword and passing back to spaetz.

comment:7 Changed 7 years ago by spaetz

Aye, resizing should be done. (there is a TODO comment that it should be done actualy). I was going for babysteps here. Integrating the avatar infrastructure would have been a good first step, and resizing could have come as a second step (to make reviewing easier).

I'll see if I can get a resizing task for the avatar creation and ask for review again.

comment:8 Changed 7 years ago by Christopher Allan Webber

Milestone: 0.3.30.3.4

I think the resizing aspect is pretty critical to get this merged; bumping to 0.3.4

comment:9 Changed 6 years ago by Christopher Allan Webber

Status: assignedin_progress

Hi! I'm moving this ticket from "assigned" to in_progress per our new workflow. Please update the ticket and let us know if you're still working on this. If you are, super great! If not, we'll remove the claim and move it back to "accepted" in a couple of weeks.

Thanks!

comment:10 Changed 6 years ago by Christopher Allan Webber

Milestone: 0.4.00.4.1

Moving to 0.4.1

comment:11 Changed 6 years ago by Christopher Allan Webber

Milestone: 0.5.00.6.0

comment:12 Changed 6 years ago by Christopher Allan Webber

Milestone: 0.6.00.7.0

comment:13 Changed 5 years ago by Christopher Allan Webber

Milestone: 0.7.0

This isn't really urgent and so I'm removing the milestone. Someone is more than welcome to pick it up though.

comment:14 Changed 5 years ago by jan

I’d say this is urgent. ;)

comment:15 Changed 5 years ago by spaetz

Owner: spaetz deleted
Status: in_progressaccepted

Sorry, I am drowning myself and won't be getting to improve this further myself.

Note: See TracTickets for help on using tickets.