the avatar image is necessary

[Charlie Vegan]

need an option to upload an avatar, I think something elemental.

[spaetz]

​https://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin/commits/WIP/499_avatars

has now an implementation allowing a user to upload their own avatar image. The only caveat is that there is no content and image size sanity checking. This should be implemented as part of the form field validation step using PIL.

[spaetz]

Modified above patches slightly after Elrond's review, now in branch formerge/499_avatars
Updated, the branch to current master. Elrond had this one reviewed once. Is it OK for merging?

[Christopher Allan Webber]

This looks good for what's there. However, I tend to wonder if we don't need the ability to have the avatar resized? I think it's maybe a bad thing to allow anyone to set any sized avatar... someone could upload really absurdly large and it would result in a not really great experience IMO.

I think we should have a task pushed out to celery to resize the avatar before it's added and committed.

Removing the review keyword and passing back to spaetz.

[spaetz]

Aye, resizing should be done. (there is a TODO comment that it should be done actualy). I was going for babysteps here. Integrating the avatar infrastructure would have been a good first step, and resizing could have come as a second step (to make reviewing easier).

I'll see if I can get a resizing task for the avatar creation and ask for review again.

[Christopher Allan Webber]

I think the resizing aspect is pretty critical to get this merged; bumping to 0.3.4

[Christopher Allan Webber]

Hi! I'm moving this ticket from "assigned" to in_progress per our new workflow. Please update the ticket and let us know if you're still working on this. If you are, super great! If not, we'll remove the claim and move it back to "accepted" in a couple of weeks.

Thanks!

[Christopher Allan Webber]

Moving to 0.4.1

[Christopher Allan Webber]

This isn't really urgent and so I'm removing the milestone. Someone is more than welcome to pick it up though.

[jan]

I’d say this is urgent. ;)

[spaetz]

Sorry, I am drowning myself and won't be getting to improve this further myself.