Opened 9 years ago
Closed 8 years ago
#453 closed enhancement (fixed)
Enable/disable comments option
Reported by: | Jeremy Pope | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | programming | Keywords: | bitesized |
Cc: | Parent Tickets: |
Description
There should be the option to disable the comments as desired. My instance is a single user instance (and is planned to stay a single user instance) and until federation hits, the 'Add comment' is misleading to visitors since they can't actually add a comment.
Subtickets
Change History (8)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Owner: | set to David Thompson |
---|---|
Status: | new → assigned |
comment:3 Changed 9 years ago by
Added an 'allow_comments' configuration option to config_spec.ini. Comments are not displayed if this option is not set to True. POSTing a comment will result in a message being displayed if allow_comments is set to False.
Changes are in this git branch: https://gitorious.org/~davethompson/mediagoblin/davethompsons-mediagoblin/commits/allowcomments
comment:4 Changed 8 years ago by
We completely missed out on this one.
Ideas:
- Show comments, if they exist, always. If it's in the db, show it. (Elrond's razor)
- Instead of HTTPFound, maybe use
return redirect(request, location=...)
. I think, we use that more often around in the code. - Maybe do a rebase. The branch is quite oldish now?
If you're ready, add a "review" keyword to this ticket. That raises the chance of getting it merged a lot.
comment:5 Changed 8 years ago by
Okay, so it took me awhile to find the time to hack on this again. But, here is the new branch!
I believe I have addressed all of Elrond's feedback. Let me know how it looks.
comment:6 Changed 8 years ago by
Keywords: | review added |
---|
comment:7 Changed 8 years ago by
Keywords: | review removed |
---|---|
Owner: | David Thompson deleted |
Status: | assigned → review |
comment:8 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
Heya. Great branch, this works perfectly. Merged!
I explained how to do this on IRC, so here's a lazy copy-pasta :)