Opened 8 years ago

Last modified 6 years ago

#414 in_progress enhancement

Ability to delete one's own comments.

Reported by: Aleksej Owned by: pythonsnake
Priority: minor Milestone:
Component: programming Keywords: test
Cc: Parent Tickets:

Description

There is currently no way to remove one's own comments.

Maybe the feature should be optional or customizable.

Subtickets

Change History (10)

comment:1 Changed 7 years ago by Christopher Allan Webber

Component: component1programming

comment:2 Changed 7 years ago by ShawnRisk

Owner: somebody deleted
Status: newassigned

comment:3 Changed 7 years ago by pythonsnake

Owner: set to pythonsnake
Status: newassigned

comment:4 Changed 7 years ago by pythonsnake

or maybe even report comments!

comment:5 Changed 7 years ago by pythonsnake

Update: this is done, but I need to update it to work with a recent MediaGoblin? version (my hacking instance is a bit out-of-date).

comment:7 Changed 7 years ago by Christopher Allan Webber

Keywords: review removed
Owner: pythonsnake deleted
Status: assignedreview

comment:8 Changed 7 years ago by Christopher Allan Webber

Owner: set to pythonsnake
Status: reviewin_progress

Heya pythonsnake, sorry this took so long to review. This looks like a really good start and actually very close. But I'm passing it back to you, with the following comments:

  • It looks like mediagoblin/user_pages/comment_confirm_delete.html wasn't checked in? The feature isn't working for me.
  • It's missing unit tests, those would be really helpful if you can find the time: both to confirm that a user can delete things, and that it fails appropriately if it wasn't the original author of the comment or an admin.
  • I think the suggestion on the /u/cwebber/m/foo-media/c/13/confirm-delete/ style URL was my suggestion. The one issue I have with this is that we're currently just pulling the comment id out and discarding the username and media slug bits. We should either also be checking against those to be sure or we should move this to a simpler URL like /c/13/confirm-delete/ probably?
  • There's more changes to the .comment_wrapper class CSS than I would expect (at most I'd expect making room for the X; I'm a bit confused why the background is black and etc).

Nonetheless this all looks very close. Thanks for working on it, I'd really love to see this get in! :)

comment:9 Changed 6 years ago by pythonsnake

Working on it.

comment:10 Changed 6 years ago by ShawnRisk

Keywords: test added
Note: See TracTickets for help on using tickets.