Opened 13 years ago
Closed 13 years ago
#404 closed defect (fixed)
Don't save a "medium" image unless we have to
| Reported by: | Christopher Allan Webber | Owned by: | Bassam Kurdali |
|---|---|---|---|
| Priority: | major | Milestone: | 0.3.0 |
| Component: | component1 | Keywords: | |
| Cc: | Parent Tickets: |
Description
It used to be that if the image was smaller than the maximum width/height, it would just not create a "medium" image. But when the exif rotation code was added, it was switched so that it would create a medium image no matter what.
Do something along the lines of:
if needs_exif_rotation or greater_than_maxsize:
medium creating code here
Change History (4)
comment:1 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 13 years ago
comment:3 by , 13 years ago
ok, intitial fix is on my repo on gitorious:
git://gitorious.org/~slikdigit/mediagoblin/slikdigit-mediagoblin.git
commit:
https://gitorious.org/~slikdigit/mediagoblin/slikdigit-mediagoblin/commit/0f8221dca40dc8628f8b8146a2ef2043e95781c2
Note:
See TracTickets
for help on using tickets.
Ok, I've fixed this bug afaik, I'm posting here to ask if *not* creating the medium dict entry in media_files_dict will have any sideeffects that we don't want?
earlier I tried creating it with just the same filepath as original in the value, that backfired when deleting images because it would try to delete the same file twice, and fail the second time (perhaps deleting files could be made more fault tolerant?)