Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#402 closed enhancement (fixed)

nicer skin for video entries

Reported by: Sacha Owned by: Christopher Allan Webber
Priority: major Milestone: 0.3.0
Component: component1 Keywords:
Cc: Parent Tickets:

Description

Current skin is boring, video.js is probably the way to go for this (see videojs.com).

Subtickets

Change History (10)

comment:1 Changed 9 years ago by Sacha

Owner: changed from somebody to Sacha
Status: newassigned

comment:2 Changed 9 years ago by Christopher Allan Webber

So the steps that are necessary to do this:

  • Add video.js to extlib/ ... make sure it includes license files of some sort
  • Symlink into mediagoblin/static/js/ with *relative* paths, probably like so
    cd mediagoblin/static/js/extlib/
    ln -s ../../../../video.js/video.js ./  # or whatever
    
  • Include that via request.staticdirect in the mediagoblin_head jinja2 template block
    {% block mediagoblin_head %}
      <script type="text/javascript"
              src="{{ request.staticdirect('/js/extlib/video.js') }}"></script>
    {% endblock %}
    
  • profit???

comment:3 Changed 9 years ago by Christopher Allan Webber

Actually, to include the content of the previous block:

{% block mediagoblin_head %}
  {{ super() }}
  <script type="text/javascript"
          src="{{ request.staticdirect('/js/extlib/video.js') }}"></script>
{% endblock %}
Last edited 9 years ago by Christopher Allan Webber (previous) (diff)

comment:4 Changed 9 years ago by Sacha

Owner: changed from Sacha to Christopher Allan Webber

comment:5 Changed 9 years ago by Christopher Allan Webber

Type: defectenhancement

comment:6 Changed 9 years ago by Christopher Allan Webber

Resolution: fixed
Status: assignedclosed

Looks soooooo awesome! Merged!

comment:7 Changed 9 years ago by joar

It seems the native controls are still visible beneath the video-js controls, perhaps we should remove the controls attribute from the <video> tag too.

comment:8 in reply to:  7 ; Changed 9 years ago by Sacha

Replying to joar:

It seems the native controls are still visible beneath the video-js controls, perhaps we should remove the controls attribute from the <video> tag too.

can you tell me what browser you're seeing this in?

comment:9 in reply to:  8 Changed 9 years ago by joar

Replying to chemhacker:

Replying to joar:

It seems the native controls are still visible beneath the video-js controls, perhaps we should remove the controls attribute from the <video> tag too.

can you tell me what browser you're seeing this in?

Google Chrome 19.0.1068.0 dev linux x86_64.

Iceweasel looks good.

comment:10 Changed 9 years ago by joar

It seems this is an issue specific to google-chrome-unstable. Case closed closed :)

Note: See TracTickets for help on using tickets.