Opened 9 years ago

Last modified 9 years ago

#377 closed defect (FIXED)

Make feed PubSubHubbub enabled

Reported by: Michele Azzolari Owned by: Michele Azzolari
Priority: minor Milestone: 0.2.1
Component: programming Keywords:
Cc: Parent Tickets:

Description

I created a branch [1] to make feed PubSubHubbub enabled.

To enable it add these 2 lines to your mediagoblin\_local.ini

push\_enabled = True
push\_url = 'http://pubsubhubbub.appspot.com/'

[1]
[https://gitorious.org/\ :sub:`macno/mediagoblin/macnos-mediagoblin/commits/pushatom](https://gitorious.org/`\ macno/mediagoblin/macnos-mediagoblin/commits/pushatom)



Subtickets

Change History (8)

comment:1 Changed 9 years ago by Elrond

Component: Programming
Status: NewFeedback
Stupid question: Why not enable just/when/if the url is set?
Two config settings feels a bit "too much"?



comment:2 Changed 9 years ago by Michele Azzolari

Removed one setting. If push\_url is set, we use it

[https://gitorious.org/\ :sub:`macno/mediagoblin/macnos-mediagoblin/commit/7f251b037bd5207652ca73f556e90b9633786a3c](https://gitorious.org/`\ macno/mediagoblin/macnos-mediagoblin/commit/7f251b037bd5207652ca73f556e90b9633786a3c)



comment:3 Changed 9 years ago by Elrond

Milestone: 0.2.1
Owner: set to Elvenlord Elrond
That looks good!
I'll try to merge this tomorrow.



comment:4 Changed 9 years ago by Elrond

Status: FeedbackIn Progress
Hi Michele,

I merged your tree (so please do a ``git merge upstream/master`` or
equivalent).

But (and that's the reason I'm not closing the bug):

If the remote server is broken (you can easily test this using
``http://localhost/no-such-file,`` as a ``push_urls`` setting) one
gets a big fat error page (urllib2.HTTPError exception).

I am currently unsure what is the best option for this.

My vote is on "catch the exception and add the stringified version
of the Exception as a message", so the users gets it. Maybe not the
best, but our current userbase will surely know what to do with
such a strange thing.



comment:5 Changed 9 years ago by Elrond

Owner: changed from Elvenlord Elrond to Michele Azzolari

comment:5 Changed 9 years ago by Michele Azzolari

I pushed the changes to my branch, check it out



comment:6 Changed 9 years ago by Elrond

Status: In ProgressClosed
merged!
Great work!



comment:7 Changed 9 years ago by Will Kahn-Greene

The original url for this bug was http://bugs.foocorp.net/issues/736 .
Relations:
#311: related

Note: See TracTickets for help on using tickets.