Opened 11 years ago
Closed 10 years ago
Last modified 8 years ago
#354 closed defect (fixed)
Option to stay logged in
|Reported by:||Jef van Schendel||Owned by:|
Description (last modified by )
Users don't stay logged in after leaving a MediaGoblin site. There is no option to stay logged in (via cookies, or whatever the best way to do this is).
Change History (9)
comment:1 by , 11 years ago
comment:2 by , 10 years ago
|Status:||accepted → in_progress|
Started working on this.
comment:3 by , 10 years ago
|Status:||in_progress → review|
This is my solution: branch 354-save-login. Maybe it would be better if you could set the expiry time in the site configuration.
comment:4 by , 10 years ago
|Status:||review → accepted|
BUT: It wont work fully, I think.
request.session is a new, fresh object for each request, even of the same user/session. Because it is created from the contents of the sent cookie. So the extra
.max_age will only be set on the session straight on the login action. So yes, it will affect the cookie that is set at login.
But if the cookie is modified later on by modifying the session, then there wont be any max_age and the cookie will be sent as a session cookie. I don't know, what browsers do, when cookies change from having an expire time to not having one.
If you want to test: Do anything that creates a message at the top. For example post an empty comment.
So the max_age should possibly be put in the session itself, so that it can be used later on again?
comment:5 by , 10 years ago
|Status:||accepted → review|
I pushed another, hopefully working, commit to the same branch.
comment:6 by , 10 years ago
This looks very good from my quick glance of it.
I am not able to review this further these days, really.
For someone wanting to review this:
- Boot up firebug, get the http headers thing ready. Watch out for the session cookie.
- Maybe also get up the cookie dialog to see the current cookies.
- Log in with and without the "stay logged in" option set.
- After logging in (both with and without), do something that will set a new session, like posting an empty comment.
comment:7 by , 10 years ago
Everything looks good to me and works as expected.
I have rebased against master and pushed it here: https://github.com/rodney757/mediagoblin/tree/save_login
comment:8 by , 10 years ago
|Status:||review → closed|
Okay, I merged this. Thanks!
comment:9 by , 10 years ago
The original url for this bug was http://bugs.foocorp.net/issues/707 .