./bin/gmg adduser should take password, email as arguments, and prompt if not provided

[Christopher Allan Webber]

Instead of being sequential arguments, email and password (or at least password) should be --keyword arguments. If not provided, we should prompt the user for them (and obscure the password as being entered).

This is a fairly easy and entry level task.

[Manolinux aka Mu]

I pick this one, if you don't mind.

It was indeed, very instructive. I am also enabling short options, like that:

optional arguments:
  -h, --help            show this help message and exit
  --username USERNAME, -u USERNAME
                        Username used to login
  --password PASSWORD, -p PASSWORD
                        Your supersecret word to login, beware: it could be
                        stored in your bash history
  --email EMAIL, -e EMAIL
                        Email to recieve notifications

since writing full options is quite tedious.

[Manolinux aka Mu]

Done.

Repo: [https://gitorious.org/_{manolinux/mediagoblin/manolinuxs-mediagoblin](https://gitorious.org/}manolinux/mediagoblin/manolinuxs-mediagoblin) Branch: 645_gmg_adduser_prompt

Notes:

• I created a function in utils.py 'prompt_if_not_set' (I don't know if it would be the correct location).
• I used raw_input for clear text and getpass.getpass for passwords.
• Maybe, I could make more checks on input (empty username, lengths, and so).

[Christopher Allan Webber]

Merged! Thanks so much :)

BTW, I made a few adjustments: https://gitorious.org/mediagoblin/mediagoblin/commit/bbac7663f4b05430592ac5d39f056029dc11db92

FYI for in the future:

• It would be helpful to make your code compliant to PEP-8. It really helps keep code consistent and thus more readable: http://www.python.org/dev/peps/pep-0008/

• Also, not a big deal, but I saw you did None.. I generally find that if you're doing a comparison to None rather than to False, maybe you mean "is None"... "is None" will make sure it's None, " None" is the same basically as "== False" iirc. Could be wrong though.

• Lastly, if you do string operations, best to do stuff like

  foo + u"bleh"

instead of

foo + "bleh"

This just helps us avoid some unicode decoding issues :)

Thanks much! Great work :)

[Manolinux aka Mu]

Great, thanks.

I'm new to python, so I will take your advices in much consideration :)

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/645 .