Use staticdirect instead of /mgoblin_static/

[Elrond]

templates should never use ``/mgoblin_static/`` but use
``request.staticdirect()`` instead, which uses the proper paths
from the config.

This is relevant when running mediagoblin not on / but on a subpath
like /mediagoblin/.

I have fixed the current templates (git branch will be pushed
tomorrow).

The interesting question is, if the test suite should test for
this?
If so, here's an idea on how to do it:


1. in ``test_mgoblin_app.ini`` set ``direct_remote_path`` to
   something else than /mgoblib\_static/
2. While testing: add a special "middleware" to the main App, that
   greps the rendered html for mgoblin\_static and errors out.

That way all tested paths will at least also get tested for wrong
references. At least, that's my idea on this.

[Elrond]

Assigning to me, as I need to provide a branch for the base fixes.
I will assign back to nobody when done with that part.

Set to 0.1.0, at least for my fixes, because **those** should get
into that release. The possible unit testing might go in later.

[Elrond]

Branch with the simple fixes: misc/use\_staticdirect
Assigning to Chris for branch review/merge.

Later: Should be assigned to nobody for discussing the unit testing
(main part!) of this bug.

[Christopher Allan Webber]

Merged. Sorry it took so long!

[Elrond]

Thanks for merging!

That was only the first part of this bug.

The main bug here is a suggestion:

We should make sure in the unit tests, that this does not happen
again. It's not easy to find unless one runs mediagoblin via
fastcgi in a subpath. So unit tests seem a better thing than human
testing.

[Elrond]

Okay, I have started on this on my own. I think, I'll push a branch
next week or so.

[Elrond]

Okay, my branch: idea/check\_mgoblin\_static

Comments?
Places that need better docs?

[Christopher Allan Webber]

Wow, that's really wacky. I guess it works. I'm not completely sure
what I think about this... let's talk on IRC :)

[Elrond]

I need to add some docs, move it over to the testing dir... and
push it. Will do so during the next month.

[Elrond]

Puhh. Done!

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/591 .