Opened 13 years ago

Last modified 9 years ago

#208 closed defect (FIXED)

If there are no next and previous media, the navigation buttons should not appear

Reported by: Jef van Schendel Owned by: Caleb Davis
Priority: minor Milestone: 0.0.5
Component: programming Keywords:
Cc: Parent Tickets:

Description

Speaks for itself. If you only have one piece of media for whatever
reason, the navigation still shows up. But both of the buttons are
disabled, so they may just as well be gone completely.

I have no idea how hard this is to do though.

Attached is a screenshot.



Attachments (1)

Screenshot-16.png (98.2 KB ) - added by Jef van Schendel 13 years ago.
Screenshot-16.png

Download all attachments as: .zip

Change History (8)

by Jef van Schendel, 13 years ago

Attachment: Screenshot-16.png added

Screenshot-16.png

comment:1 by Jef van Schendel, 13 years ago

Typo in the ticket title: "not disappear" should of course be "not
appear".



comment:2 by Caleb Davis, 13 years ago

Owner: set to Caleb Davis
Status: NewFeedback
Jef, like this?


.. raw:: html

   <del>
   
[https://gitorious.org/\ :sub:`cfdv/mediagoblin/cfdvs-mediagoblin/commit/e3df834a8a22a45ba77940efbd083c7d5a23764e](https://gitorious.org/`\ cfdv/mediagoblin/cfdvs-mediagoblin/commit/e3df834a8a22a45ba77940efbd083c7d5a23764e)

.. raw:: html

   </del>
   
EDIT: Chris pointed out you didn't want the Xs to go away
completely, just in the case where the user had one media item
only. Oops! How about this one?

[https://gitorious.org/\ :sub:`cfdv/mediagoblin/cfdvs-mediagoblin/commit/0a100476b24d81355342cae5320e1a5a6c83014d](https://gitorious.org/`\ cfdv/mediagoblin/cfdvs-mediagoblin/commit/0a100476b24d81355342cae5320e1a5a6c83014d)



comment:3 by Jef van Schendel, 13 years ago

Yes, that seems like it should work to me.

Thanks Caleb!



comment:4 by Caleb Davis, 13 years ago

Great, please review for merge. This was a bit of additional
template logic.



comment:5 by Christopher Allan Webber, 13 years ago

Milestone: 0.0.5

comment:5 by Christopher Allan Webber, 13 years ago

Status: FeedbackClosed
Merged. Thanks!



comment:6 by Will Kahn-Greene, 12 years ago

The original url for this bug was http://bugs.foocorp.net/issues/503 .

Note: See TracTickets for help on using tickets.