Opened 15 years ago
Last modified 15 years ago
#193 closed defect (FIXED)
{% trans %}'ify our templates
| Reported by: | Christopher Allan Webber | Owned by: | Osama Khalid |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.0.5 |
| Component: | programming | Keywords: | |
| Cc: | Parent Tickets: |
Description
We have a lot of strings in our templates, but they aren't marked for translation! As part of the process of making MediaGoblin translatable we should make all templates marked with the {% trans %} tag.
Change History (4)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
AWESOME.
I merged it! Made a few changes... fyi, there's an extra feature in Jinja2 where you can do
<a href="blah blah blah">
{%- trans -%}blah blah blah{% endtrans -%}
</a>
putting a minus at the start/end of a {% tag %} or {{ call }} thing strips all the whitespace before/after which I think makes it easier to format the templating a bit nicer.
Looks SUPER GREAT. Thanks so much for taking the time on this osamak! Now we have a real bunch of strings that are translatable up here: https://www.transifex.net/projects/p/mediagoblin/resource/mediagoblin/
Thanks again!
comment:3 by , 15 years ago
| Status: | New → Closed |
|---|

Done for all templates, but there some fixed strings in mediagoblin/submit/forms.py and mediagoblin/edit/forms.py that I am not sure how to fix.
Please pull from: git://gitorious.org/~osamak/mediagoblin/mediagoblin-osamak.git
The exact commit is: [https://gitorious.org/osamak/mediagoblin/mediagoblin-osamak/commit/8f4c9b813d306228e1eecec7551d46902c264189](https://gitorious.org/osamak/mediagoblin/mediagoblin-osamak/commit/8f4c9b813d306228e1eecec7551d46902c264189)