Opened 13 years ago

Last modified 12 years ago

#191 closed defect (FIXED)

Confirm password field

Reported by: Jan-Christoph Borchardt Owned by: Jef van Schendel
Priority: minor Milestone: 0.2.1
Component: ui Keywords:
Cc: Parent Tickets:


Confirming a password is really cumbersome and not helpful.
Remove the »confirm password« field in favor of a »show password«

For reference, see Jakob Nielsen on the topic
` <>`_

Change History (10)

comment:1 by Jef van Schendel, 12 years ago

Owner: set to Jef van Schendel

comment:1 by Jef van Schendel, 12 years ago

Status: NewIn Progress
I created a new branch that contains jQuery and a bit of code to
start this ticket:
` <>`_

So now it shows one password field and a "Show password" checkbox
underneath it to switch from hidden to visible text. With
JavaScript disabled, it only shows the one password box.

However, I think the behaviour described by J-C and on
` <>`_
intents to make visible text the default, with an option to hide
it. Is that correct? At first I had my doubts, but especially when
you first **choose** a password it actually makes a lot of sense.

comment:2 by Jef van Schendel, 12 years ago

Oh, and there's still one bug I think. Two password fields are
available, one of which hides the text and the other shows it. One
of these is always hidden, the checkbox switches between them.

However, I **think** that only the "hidden text" passworld field's
value is sent when you create an account. And that value is only
updated after you click the checkbox. So if you use the "visible
text" password field and don't click the checkbox after that, it
will send either a wrong value or an empty one.

comment:3 by Jan-Christoph Borchardt, 12 years ago

As far as I remember, for ownCloud we used this jQuery plugin:
` <>`_
and didn't have issues yet.

And no, default should be hidden, with the checkbox »show password«
unchecked by default. People still expect password fields to not
show their password in clear text - and they should not do so by
default (at least for now).

comment:4 by Jef van Schendel, 12 years ago

Oh hey, you're online. I thought you were away for some reason. :)

Ok, that's fine then, that's the current behavior. And yeah, I came
across that plugin while searching, but the code really wasn't that
difficult to write and I'd like to keep it as clean as possible.

Things that still need to be done for this ticket, off the top of
my head:

-  Isolate JS into a seperate file (by Elrond's request)
-  Put some space between the password field the checkbox
-  The bug mentioned in comment `#3 </issues/3>`_

comment:5 by Jef van Schendel, 12 years ago

Another bug: auth/change\_fp.html (where you change your password)
still uses the old method.

comment:6 by Jef van Schendel, 12 years ago

Status: In ProgressClosed
Closing this ticket since I worked out the bugs listed above
(except isolating the JS, which I'll do right now).

comment:7 by Jef van Schendel, 12 years ago

For posterity: I've isolated the JavaScript in a separate file and
I've also added it to auth/change\_fp.html.

comment:8 by Elrond, 12 years ago

Milestone: 0.2.1

comment:8 by Will Kahn-Greene, 12 years ago

The original url for this bug was .

Note: See TracTickets for help on using tickets.