Opened 13 years ago

Last modified 13 years ago

#153 closed defect (FIXED)

No need for email_sender_address / email_debug_mode in mediagoblin.mg_globals

Reported by: Christopher Allan Webber Owned by: Deb Nicholson
Priority: minor Milestone: 0.0.4
Component: programming Keywords:
Cc: Parent Tickets:


We store some global variables in\_globals, though a
couple of them are just pulled right out of the application config,
which is already stored in\\_config
anyway. So that's unnecessary duplication.

So there are a few steps to this.

-  In mediagoblin/mg\ find the email\_debug\_mode and
   email\_sender\_address defaults lines, and remove them (and their
   comments too)
-  In mediagoblin/ find the section that has the
   setup\_globals() call, and remove the couple of lines that specify
   email\_sender\_address and email\_debug\_mode from the app\_config
-  grep for any instances of mg\\_sender\_address and
   change to mg\\_config['email\_sender\_address'] ...
   probably just in mediagoblin/auth/
-  grep for any instances of mg\\_debug\_mode and
   change to mg\\_config['email\_debug\_mode'] ...
   probably all in mediagoblin/
-  Make sure tests pass still with ./bin/nosetests

Change History (4)

comment:1 by Deb Nicholson, 13 years ago

[\ :sub:`eximious/mediagoblin/eximiouss-mediagoblin/commits/bug443\_remove\_email\_globals](`\ eximious/mediagoblin/eximiouss-mediagoblin/commits/bug443\_remove\_email\_globals)

comment:2 by Elrond, 13 years ago

Status: NewIn Progress
From my first quick look, this looks fine!

Note: Running tests is via "./"

comment:3 by Christopher Allan Webber, 13 years ago

Status: In ProgressClosed
Merged! Thanks, Deb!

comment:4 by Will Kahn-Greene, 12 years ago

The original url for this bug was .

Note: See TracTickets for help on using tickets.