Opened 12 years ago

Last modified 12 years ago

#153 closed defect (FIXED)

No need for email_sender_address / email_debug_mode in mediagoblin.mg_globals

Reported by: Christopher Allan Webber Owned by: Deb Nicholson
Priority: minor Milestone: 0.0.4
Component: programming Keywords:
Cc: Parent Tickets:

Description

We store some global variables in mediagoblin.mg\_globals, though a
couple of them are just pulled right out of the application config,
which is already stored in mediagoblin.mg\_globals.app\_config
anyway. So that's unnecessary duplication.

So there are a few steps to this.


-  In mediagoblin/mg\_globals.py find the email\_debug\_mode and
   email\_sender\_address defaults lines, and remove them (and their
   comments too)
-  In mediagoblin/app.py find the section that has the
   setup\_globals() call, and remove the couple of lines that specify
   email\_sender\_address and email\_debug\_mode from the app\_config
-  grep for any instances of mg\_globals.email\_sender\_address and
   change to mg\_globals.app\_config['email\_sender\_address'] ...
   probably just in mediagoblin/auth/lib.py
-  grep for any instances of mg\_globals.email\_debug\_mode and
   change to mg\_globals.app\_config['email\_debug\_mode'] ...
   probably all in mediagoblin/util.py
-  Make sure tests pass still with ./bin/nosetests



Subtickets

Change History (4)

comment:1 Changed 12 years ago by Deb Nicholson

[https://gitorious.org/\ :sub:`eximious/mediagoblin/eximiouss-mediagoblin/commits/bug443\_remove\_email\_globals](https://gitorious.org/`\ eximious/mediagoblin/eximiouss-mediagoblin/commits/bug443\_remove\_email\_globals)



comment:2 Changed 12 years ago by Elrond

Status: NewIn Progress
From my first quick look, this looks fine!

Note: Running tests is via "./runtests.sh"



comment:3 Changed 12 years ago by Christopher Allan Webber

Status: In ProgressClosed
Merged! Thanks, Deb!



comment:4 Changed 11 years ago by Will Kahn-Greene

The original url for this bug was http://bugs.foocorp.net/issues/443 .

Note: See TracTickets for help on using tickets.