No need for email_sender_address / email_debug_mode in mediagoblin.mg_globals

[Christopher Allan Webber]

We store some global variables in mediagoblin.mg_globals, though a couple of them are just pulled right out of the application config, which is already stored in mediagoblin.mg_globals.app_config anyway. So that's unnecessary duplication.

So there are a few steps to this.

• In mediagoblin/mg_globals.py find the email_debug_mode and email_sender_address defaults lines, and remove them (and their comments too)
• In mediagoblin/app.py find the section that has the setup_globals() call, and remove the couple of lines that specify email_sender_address and email_debug_mode from the app_config
• grep for any instances of mg_globals.email_sender_address and change to mg_globals.app_config['email_sender_address'] ... probably just in mediagoblin/auth/lib.py
• grep for any instances of mg_globals.email_debug_mode and change to mg_globals.app_config['email_debug_mode'] ... probably all in mediagoblin/util.py
• Make sure tests pass still with ./bin/nosetests

[Deb Nicholson]

[https://gitorious.org/_{eximious/mediagoblin/eximiouss-mediagoblin/commits/bug443_remove_email_globals](https://gitorious.org/}eximious/mediagoblin/eximiouss-mediagoblin/commits/bug443_remove_email_globals)

[Elrond]

From my first quick look, this looks fine!

Note: Running tests is via "./runtests.sh"

[Christopher Allan Webber]

Merged! Thanks, Deb!

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/443 .