Opened 13 years ago
Last modified 13 years ago
#151 closed defect (FIXED)
Order comments by date, ascending
Reported by: | Aaron Williamson | Owned by: | Inconexo ø |
---|---|---|---|
Priority: | minor | Milestone: | 0.2.0 |
Component: | programming | Keywords: | |
Cc: | Parent Tickets: |
Description
On the media "home" page, comments on photos are currently sorted in descending order by date (i.e. reverse-chronological order, like a blog). The standard order is ascending order by date. This requires a change to media\_home() in mediagoblin/user\_pages/views.py
Change History (13)
comment:2 by , 13 years ago
Milestone: | 0.0.4 → 0.0.5 |
---|
We release 0.0.4, so I'm bumping this to 0.0.5.
comment:3 by , 13 years ago
I don't really agree with this ticket. This means that new comments will be buried, possibly pages deep, and probably never will be seen! This seems to disincentivize posting new comments.
comment:4 by , 13 years ago
Christopher Webber wrote: I don't really agree with this ticket. This means that new comments will be buried, possibly pages deep, and probably never will be seen! This seems to disincentivize posting new comments. +1 If I'm reading a support forum (lots of Q&A), then I expect comments to come in chronological order. Commenting on pictures tends to be less chronologically linear. It's more like, - love it! - how'd you do that? - I used the Gimp - this reminds me of the time when ... - totally, here's a link to my time when ... - rant rant rant rant - this should be at the top reddit's 'best', 'new', and other sorting orders may inform this decision also.
comment:5 by , 13 years ago
I'd **love** to have reddit-style "best" & rated tree style comments. However that seems like a distant future thing... so for now...
comment:6 by , 13 years ago
Re: threading and such. Personally I think we should keep complexity here to a minimum. Caleb's example seem realistic, and one level of indentation seems to work well (it lets the poster respond to individual comments). But I think we should not add much more than that, since we're not making a discussion site but an image sharing site after all. Just saying I don't think we should go all-out on this. Let's keep it nice and simple, there's a lot of value in that too. :)
comment:7 by , 13 years ago
Milestone: | 0.0.5 → 0.1.0 |
---|
comment:7 by , 13 years ago
Okay, so we aren't doing threading. I guess people seem to be in favor of doing things as this ticket suggests.
comment:8 by , 13 years ago
Milestone: | 0.1.0 → 0.2.0 |
---|
comment:9 by , 13 years ago
Owner: | set to |
---|
comment:8 by , 13 years ago
Fixed. repo: git://gitorious.org/~inconexo/mediagoblin/inconexos-mediagoblin.git branch: 441\_comment\_order Note: I added an optional parameter in MediaEntry::get\_comments function to specify order parameter. It will allow in the future, if we want, to let the user order the comments as he prefers. Hope that's ok.
comment:9 by , 13 years ago
Status: | New → Closed |
---|
Oh great! Merged, and took advantage of your option. Users can now set what they prefer. Comments are ascending by default, but if you'd prefer descending, just change in mediagoblin\_local.ini: :: [mediagoblin] # ... comments_ascending = false Thanks! :D
comment:10 by , 13 years ago
The original url for this bug was http://bugs.foocorp.net/issues/441 .
Relations:
#179: duplicated
Note:
See TracTickets
for help on using tickets.