Opened 12 years ago
Last modified 8 years ago
#114 closed defect (FIXED)
Ability to delete media
|Reported by:||Jef van Schendel||Owned by:||Christopher Allan Webber|
Don't know if anyone is working on this... I've added some text for a delete link to the media pages. Only thing that's missing is, well, the ability to delete things. :)
Change History (16)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
We could add a timeout to make the process "safer". After clicking on "Delete", the files aren't actually deleted yet, just hidden. The changes can still be undone. Then after a while, it will be deleted for real. Don't know if that makes sense. Probably makes the whole thing too complex.
comment:3 by , 12 years ago
`http://docs.celeryproject.org/en/latest/userguide/executing.html#eta-and-countdown <http://docs.celeryproject.org/en/latest/userguide/executing.html#eta-and-countdown>`_ Assuming we do deletion of media via celery, we can set a delay via eta like above. I'm not sure if that's the best route or not. Maybe if anything, eta can be an option.
comment:4 by , 12 years ago
comment:4 by , 12 years ago
Setting to 2 hours: If we just want a simple "delete" function, this one can be handled by a newcommer with some help from people around. Even a confirmation page is simple. Get from the "delete"-link to the actual (post enabled form) for deletion. Very straight forward.
comment:5 by , 12 years ago
0.0.3 meeting result
comment:6 by , 12 years ago
I feel like I've been squatting on this one a bit too long. Released until I can get to it, or someone else grabs it.
comment:7 by , 12 years ago
Assigning to Larisa! Thanks Larisa, ping me on IRC if you have any questions!
comment:8 by , 12 years ago
|Milestone:||0.0.4 → 0.0.5|
We release 0.0.4, so I'm bumping this to 0.0.5.
comment:9 by , 12 years ago
Closed by `https://gitorious.org/mediagoblin/mediagoblin/merge\_requests/18 <https://gitorious.org/mediagoblin/mediagoblin/merge_requests/18>`_ Feel free to close or report problems with my changes.
comment:10 by , 12 years ago
Hiya Mark! From first glance, this looks good! I'll try to check seriously tonight. However I'd prefer it if you would split up different issues into different branches. For example, in this case it would be good to have a unicode fix branch and a delete branch.. for example, if the unicode stuff was ready but the delete stuff wasn't, I could merge in the unicode stuff while the delete stuff is still being finished. It also makes our git commit history clearer if you commit one issue per commit. `http://wiki.mediagoblin.org/Git\_workflow <http://wiki.mediagoblin.org/Git_workflow>`_ However, looking good, and **GREAT** job just diving into the codebase! More thorough review tonight or at least shortly I hope!
comment:11 by , 12 years ago
Tested, reviewed, and added notice about the permanentness of a deletion. `https://github.com/jwandborg/mediagoblin/tree/f403\_ability\_to\_delete <https://github.com/jwandborg/mediagoblin/tree/f403_ability_to_delete>`_
comment:12 by , 12 years ago
Hm. I looked, in general this is very close to being ready for merge, except a few things: - The actual media of the MediaEntry is not deleted... just the record of it. We should iterate through all media\_files and attachment\_files and actually delete all of these from the public\_store. - The URL doesn't make sense to me... when I try deleting, I get a URL like: `http://127.0.0.1:6543/u/cwebber/m/4e35f68c48b1520a5600001b/confirm/ <http://127.0.0.1:6543/u/cwebber/m/4e35f68c48b1520a5600001b/confirm/>`_ ... but /confirm/? /confirm/ what ;) I think /confirm-delete/ makes more sense. - Not sure why a mediagoblin/confirm/ submodule was made... this seems to belong in mediagoblin/user\_pages/. - Could use some tests, particularly making sure that other users can't delete your media for you! ;) I merged this into master (there were some conflicts) and added a fix for the second bullet point (made it /confirm-delete/) but haven't done the rest. You can merge from: [https://gitorious.org/\ :sub:`cwebber/mediagoblin/cwebbers-mediagoblin](https://gitorious.org/`\ cwebber/mediagoblin/cwebbers-mediagoblin)
comment:13 by , 12 years ago
|Status:||New → Feedback|
Updated at `https://github.com/jwandborg/mediagoblin/tree/f403\_ability\_to\_delete <https://github.com/jwandborg/mediagoblin/tree/f403_ability_to_delete>`_ - Files and attachments in public\_store that are related to the entry are now deleted - Removed ``confirm`` stuff and put it in ``user_pages`` - Created tests for the ``media_confirm_delete`` functionality Cheers,
comment:14 by , 12 years ago
|Status:||Feedback → Closed|
Merged, by the skin of our noses for this release! Nice job everyone on this!
comment:15 by , 11 years ago
The original url for this bug was http://bugs.foocorp.net/issues/403 .
Note: See TracTickets for help on using tickets.