atom feed fails when untitled media is included

[ayleph]

Trying to view an atom feed which includes media without a title returns a server error. The log output is below.

Error - <type 'exceptions.ValueError'>: title is required
URL: https://goblinrefuge.com/mediagoblin/u/joauti/atom/
File '/path/to/mediagoblin/lib/python2.7/site-packages/Paste-1.7.5.1-py2.7.egg/paste/exceptions/errormiddleware.py', line 144 in __call__
  app_iter = self.application(environ, sr_checker)
File '/path/to/mediagoblin/lib/python2.7/site-packages/Paste-1.7.5.1-py2.7.egg/paste/urlmap.py', line 203 in __call__
  return app(environ, start_response)
File '/path/to/mediagoblin/mediagoblin/app.py', line 268 in __call__
  return self.call_backend(environ, start_response)
File '/path/to/mediagoblin/lib/python2.7/site-packages/Werkzeug-0.9.6-py2.7.egg/werkzeug/wsgi.py', line 588 in __call__
  return self.app(environ, start_response)
File '/path/to/mediagoblin/mediagoblin/app.py', line 245 in call_backend
  response = controller(request)
File '/path/to/mediagoblin/mediagoblin/user_pages/views.py', line 542 in atom_feed
  'type': 'text/html'}])
File '/path/to/mediagoblin/lib/python2.7/site-packages/Werkzeug-0.9.6-py2.7.egg/werkzeug/contrib/atom.py', line 144 in add
  self.entries.append(FeedEntry(*args, **kwargs))
File '/path/to/mediagoblin/lib/python2.7/site-packages/Werkzeug-0.9.6-py2.7.egg/werkzeug/contrib/atom.py', line 294 in __init__
  raise ValueError('title is required')
ValueError: title is required

So how do you get media without a title? Upload media, edit it, clear the title, and save changes. Maybe saving media with no title should not be allowed.

[Ben Sturmfels]

Marking as "bitesized" since this is self-contained and should be fairly straightforward to fix. The feed should accommodate whatever is in the database as the title - we can't necessarily rely on input validation.

[Ben Sturmfels]

Fixed on master branch:
​http://git.savannah.gnu.org/cgit/mediagoblin.git/commit/?id=0e9e57ea306dd6aad2283f2998a54314b4cf448f

Closing this issue.