In mediagoblin/media_types/video/util.py, skip_transcode

The return type of tags.get_string is a tuple, (bool, value) (ref ​https://lazka.github.io/pgi-docs/Gst-1.0/structs/TagList.html#Gst.TagList.get_string) This code assumes that the return value is just a string. As such, it will always return False.

Example:

39 if configmime_types and tags.get_string('mimetype'): 40 if not tags.get_string('mimetype') in configmime_types: 41 return False

If there is no mimetype string in tags, then tags.get_string('mimetype') returns:

(False, None)

Which allows the test on line 40 to pass. Of course, (False, None) does not appear in the list of mimetypes in the config.

In each case, the initial existence test needs a [0] after the get_string, and the second test needs a [1] after the get_string. E.g.:

39 if configmime_types and tags.get_string('mimetype')[0]: 40 if not tags.get_string('mimetype')[1] in configmime_types: 41 return False

(raised as anongoblin as registration is disabled)

Hi, I'm partiticipating to the opensource distributed searchengine ​YACY. Thus I like to encourage you, to offer webspiders an sitemap.xml file (and refer them in the robots.txt): ​https://en.wikipedia.org/wiki/Sitemaps

This allows the bot to just walk trough the flat list and he doesn't has to get the webstructure out of the parsed HTML pages. This avoids that the searchengine misses some content and speeds up the analysis process.

When looking at user.html in order to have plugins insert content, I found that it is horrible. The logic of whether a user is activated and what to display in that case is fully embedded in the template. Having this amount of logic in your template makes it slow and hard to develop alternative themes.

I patched it to use user_nonactive.html in case we have a non-yet active user (or one that was disabled).

Please review and pull the "master" branch at my repo: git@…:mediagoblin/spaetz-mediagoblin.git (it is still the same address as earlier on).

This is the commit in question: ​http://gitorious.org/mediagoblin/spaetz-mediagoblin/commit/51b4318079d2dce51e58be3f5ea95bc825301e54