Changes between Initial Version and Version 1 of Ticket #687, comment 2


Ignore:
Timestamp:
Jul 8, 2013, 4:48:20 AM (11 years ago)
Author:
Ben Sturmfels

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #687, comment 2

    initial v1  
    1 I've attached a patch to add the `User.url_for_self` function. This is my first patch to MediaGoblin, so I'd appreciate some feedback.
    2 
    3 I'm a bit unsure about the `urlgen` function. I can see that it's a reference to the `build_proxy` function of a `Request` in `mediagoblin.app.call_backend`, but it's not clear to me what it actually is. `build_proxy` could do with some docs in this regard.
    4 
    5 I'm also not sure whether it's useful to allow `**kwargs` on `url_to_self` - I'm doing this because this is how it's done in `mixin.MediaEntryMixin.url_for_self`.
     1(irrelevant comment removed - was for wrong ticket)