Changes between Initial Version and Version 2 of Ticket #668


Ignore:
Timestamp:
Mar 23, 2013, 12:39:58 PM (11 years ago)
Author:
Elrond
Comment:

some small changes to example pseudo code, mostly suggesting a SessionManager class.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #668

    • Property Type defect → enhancement

  • Ticket #668 – Description

    initial v2  
    2323        self.clear()
    2424        self.save()
    25 
    26     @classmethod
    27     def from_cookie_string(cls, cookie):
    28         if not cookie:
    29             return cls()
    30         ...
    3125}}}
    3226
    … …  
    3529
    3630{{{
    37 def load_session_from_cookie(request, cookie_name):
    38     cookie = request.get_cookie(cookie_name)
    39     m = BadCookie.query.filter_by(cookie = cookie)
    40     if m:
    41       _log.warn("Bad cookie received: %s", m.reason)
    42       raise BadRequest()
    43     requestion.session = MGSession.from_cookie_string(cookie)
     31class SessionManager(object):
     32    def load_session_from_cookie(request, cookie_name):
     33        cookie = request.get_cookie(cookie_name)
     34        if not cookie:
     35            request.session = MGSession()
     36            return
     37        m = BadCookie.query.filter_by(cookie = cookie)
     38        if m:
     39            _log.warn("Bad cookie received: %s", m.reason)
     40            raise BadRequest()
     41        parsed_dict = self.signer.loads(cookie, max_age=...)
     42        requestion.session = MGSession(parsed_dict)
    4443}}}
    4544