Changes between Initial Version and Version 1 of Ticket #5617, comment 4


Ignore:
Timestamp:
Mar 8, 2021, 3:00:08 AM (3 years ago)
Author:
Olivier Mehani

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5617, comment 4

    initial v1  
    55X-Sendfile sounds like a promising way to do it. Reading the NGINX doc, there is also support for it in lighthttpd and Apache [0], so it's good we're not prescribing too much here.
    66
    7 I'd just implement it as a completely separate feature orthogonal to private mode, though, and this should allow disabling it completely in dev.
     7I'd just implement it as a completely separate feature orthogonal to private mode, though, and this should allow disabling it completely in dev: either send the file, or just add the X-Sendfile header if configured to do so.
    88
    99The next bit of feature once that is implemented would be sharing specific content to unlogged users. I think X-Sendfile could be used in the same way, but we'd need to have some management of the shared URLs. At the moment, I just share the direct URLs to the files, but it's clearly a bug, not a feature (;