Opened 4 years ago
Closed 4 years ago
#5583 closed enhancement (no-action)
"Create Account" and "Start an Instance" are squished together
| Reported by: | anongoblin | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | graphic design/interface | Keywords: | css, button |
| Cc: | muto.lachen@… | Parent Tickets: |
Description
On the main starting page of Mediagoblin (when the user is logged out), there are two buttons:
"Create an account on this site" and
"Set up MediaGoblin on your own server".
The two buttons appear to have no margin between them, forcing them to be as close together as possible.
This is using the "base.css" theme.
Attachments (3)
Change History (11)
by , 4 years ago
| Attachment: | issue_5583.patch added |
|---|
follow-up: 2 comment:1 by , 4 years ago
| Cc: | added |
|---|
Hi Muto Lachen,
Thanks for taking the time to contribute, and sorry for the delay in replying!
Would you mind attaching an image of the buttons that are too close together? I've attached an image of what I'm seeing, before applying your patch - it looks ok on the default theme. What theme do you have configured in your mediagoblin.ini?
Regards,
Ben
by , 4 years ago
| Attachment: | Screen Shot 2020-04-02 at 02.51.31.png added |
|---|
Screenshot without patch applied
by , 4 years ago
| Attachment: | firefox-nopatch.png added |
|---|
A Firefox screenshot demonstrating that the buttons are close together.
follow-up: 3 comment:2 by , 4 years ago
Replying to Ben Sturmfels:
Hi Muto Lachen,
Thanks for taking the time to contribute, and sorry for the delay in replying!
Would you mind attaching an image of the buttons that are too close together? I've attached an image of what I'm seeing, before applying your patch - it looks ok on the default theme. What theme do you have configured in your mediagoblin.ini?
I replied via email, but I don't know if it will be publicly visible.
On Firefox 72 and Icecat 68, the buttons are close together (attached image: firefox-nopatch.png).
On KDE's Falkon, this issue does not exist, *however*, when I apply the patch to fix the Firefox issue, strangely enough, Falkon doesn't see any additional spacing.
I didn't specify a theme in mediagoblin.ini (which should make Mediagoblin use the default theme).
follow-up: 4 comment:3 by , 4 years ago
Replying to anongoblin:
I replied via email, but I don't know if it will be publicly visible.
I can't see your image sorry. Could you please us the "attach file" button to upload your screenshot?
follow-up: 5 comment:4 by , 4 years ago
Replying to Ben Sturmfels:
I can't see your image sorry. Could you please us the "attach file" button to upload your screenshot?
Hey there. It's still me (Muto), I just registered an account.
I did attach the file. Underneath the original post, the "attachments" dropdown menu should include all attachments regarding this ticket. Both our screenshots of the buttons without the patch applied are there.
In case the link is not showing up for you:
https://issues.mediagoblin.org/attachment/ticket/5583/firefox-nopatch.png
follow-up: 7 comment:5 by , 4 years ago
Replying to Ben Card:
Hey there. It's still me (Muto), I just registered an account.
I did attach the file. Underneath the original post, the "attachments" dropdown menu should include all attachments regarding this ticket. Both our screenshots of the buttons without the patch applied are there.
In case the link is not showing up for you:
https://issues.mediagoblin.org/attachment/ticket/5583/firefox-nopatch.png
Thanks Ben - I can see the screenshot now. I've tried this on a range of devices and browsers and I'm not able to replicate it. I've tried Icecat 68.6.0esr (Guix), Icecat 52.3.0 (Trisquel) Chromium 80.0.3987.149 (Guix) and a couple of phones.
The fonts in your screenshot also seem a little larger than what I'm seeing. Is everything loading correctly in Firefox's developer console? Is it possible that you have a plugin blocking the include Lato font or something?
comment:6 by , 4 years ago
Also just tried Firefox 68.5.0esr (Debian) and couldn't replicate the spacing issue. This is on a new install based on the master branch of MediaGoblin.
comment:7 by , 4 years ago
Replying to Ben Sturmfels:
The fonts in your screenshot also seem a little larger than what I'm seeing. Is everything loading correctly in Firefox's developer console? Is it possible that you have a plugin blocking the include Lato font or something?
Aha! It's good that you mentioned fonts. It totally slipped my mind that I don't allow websites to load custom fonts.
This is an error on my side. It is not an issue at all. This ticket can be closed. Sorry for wasting your time!
comment:8 by , 4 years ago
| Resolution: | → noaction |
|---|---|
| Status: | new → closed |
A patch file addressing the issue (add margin: 1px to both button classes)