Opened 15 years ago
Last modified 14 years ago
#369 closed defect
Thread locally scoped gettext — at Version 2
| Reported by: | Christopher Allan Webber | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.3.1 |
| Component: | programming | Keywords: | bitesized |
| Cc: | Parent Tickets: |
Description (last modified by )
Currently mediagoblin is not threadsafe, but really the only reason for this is mg_globals.gettext which is set at the start of every request. So if there are two threads running in parallel these might get clobbered.
However python has some thread-local scoping: http://docs.python.org/library/threading.html#threading.local
We could probably use that. SQLAlchemy has some thread-scoped session, so theoretically it uses this, or we could look at what it does use: http://www.sqlalchemy.org/docs/orm/session.html#sqlalchemy.orm.scoped_session
Not super high priority as preforking does work fine-ish, but would be very nice to have.
Change History (2)
comment:1 by , 15 years ago
comment:2 by , 14 years ago
| Description: | modified (diff) |
|---|---|
| Milestone: | → 0.3.1 |
Marking for 0.3.1... would really like to see this happen and get rolled in.
The original url for this bug was http://bugs.foocorp.net/issues/727 .