Custom Query (1173 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (154 - 156 of 1173)

Ticket Resolution Summary Owner Reporter
#647 fixed Uncontrolled reading of files into memory Jakob Kramer
Description

Hi!

When I was looking at the attachments source code I have seen code like this:

with file:

file.write(another_file.read())

This is dangerous because you read another_file into memory completely and this can lead to MemoryErrors. There is a function shutil.copyfileobj that already does what we need: reading chunk for chunk into memory and writing it to another file object.

#648 fixed STL (3D) media type: buttons have redundant tooltips, one is wrong Aleksej
Description

https://gitorious.org/mediagoblin/mediagoblin/blobs/master/mediagoblin/templates/mediagoblin/media_displays/stl.html#line110

#651 fixed Switch to Pillow? Christopher Allan Webber
Description

This has been mentioned by willkg in several previous bugs: #392 #57 (and one where someone mentioned it as a fix: #412) but maybe we should switch from PIL to Pillow; PIL seems to be better maintained: https://pypi.python.org/pypi/Pillow/

However, we shouldn't just make this switch without considering the implications. For example, we are currently shooting for Debian packaging, but Pillow is not packaged in Debian. Pillow is apparently backwards compatible though?

Batch Modify
Note: See TracBatchModify for help on using batch modify.
Note: See TracQuery for help on using queries.