Opened 12 years ago
Closed 12 years ago
#437 closed defect (fixed)
Wrap bio text in <div> instead of <p>
| Reported by: | joar | Owned by: | Christopher Allan Webber |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | graphic design/interface | Keywords: | bitesized |
| Cc: | Jef van Schendel, Emma.C.Echo@… | Parent Tickets: |
Description
Our markdown library wraps the text in a div, that div breaks out of the <p> scope (as we are working with HTML, not XHTML) and then we get an orphaned </p> tag.
Change History (8)
follow-up: 2 comment:1 by , 12 years ago
comment:2 by , 12 years ago
Replying to gandaro:
We could simply remove the surrounding
<p>, could not we?
I think it's safe to do that. As long as our markdown library stays the same.
For future-proofing we'd perhaps change the surrounding <p> to a <div>, and give it a class.
comment:3 by , 12 years ago
| Keywords: | bitesized added |
|---|
comment:4 by , 12 years ago
| Owner: | set to |
|---|---|
| Status: | new → accepted |
follow-up: 6 comment:5 by , 12 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
| Status: | accepted → assigned |
I have replaced the paragraph tags with classed div tags. Here is the commit to my branch.
comment:6 by , 12 years ago
Replying to LotusEcho:
I have replaced the paragraph tags with classed div tags. Here is the commit to my branch.
Unfortunately there seems to have been a misunderstanding. I would not like to get rid of all paragraph tags, just one :)
The paragraph tag that shouldn't exist is located at https://gitorious.org/~lotusecho/mediagoblin/lotusechos-mediagoblin/blobs/master/mediagoblin/templates/mediagoblin/utils/profile.html#line22.
What needs to be done is simply to remove it, it might sound like an insultingly silly small task, but I didn't know exaclyt where it was when I posted this bug, and if you want to you are more than welcome to submit a fix that doesn't have the paragraph tags around {{ user.bio_html }}.
follow-up: 8 comment:7 by , 12 years ago
Alright. I made the indicated change in addition I fixed a </p> which was typed as <p/> which could lead to validation errors as well if the user did not exist. I reset my branch back to master and made the changes.
comment:8 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Replying to LotusEcho:
Alright. I made the indicated change in addition I fixed a </p> which was typed as <p/> which could lead to validation errors as well if the user did not exist. I reset my branch back to master and made the changes.
Merged and pushed, thank you! :)
We could simply remove the surrounding
<p>, could not we?