id	summary	reporter	owner	description	type	status	priority	milestone	component	resolution	keywords	cc	parents
5395	Look into why session is not used on AlembicMigrationManager	Jessica Tallon		"I noticed when debugging #5391 that migrations were forced to use SQLite which was defined in alembic.ini. I've pushed a fix for this which sets that option based on mediagoblin.ini however we shouldn't need to do this. We're providing a session on the manager which seems to be completely ignored, this leads to misleading code.

We need to decide between these two options:

1. We remove the session from AlembicMigrationManager to make it obvious alembic will internally open a new one
2. We make it so Alembic uses our database connection/session we've provided so it doesn't open another.

The way the code looks having a database connection we've setup but (seemingly) not using it is misleading and probably why it wasn't spotted earlier."	defect	closed	minor		programming	fixed	alembic, migrations, db	Christopher Allan Webber berkerpeksag