id	summary	reporter	owner	description	type	status	priority	milestone	component	resolution	keywords	cc	parents
5033	make ignores VIRTUALENV setting	ayleph		"On my system (Arch Linux), `virtualenv2` is the proper executable for creating a python2 virtualenv. This is correctly determined by `./configure` as shown in the following output.

{{{
~/mediagoblin-0.8.0 $ ./configure 
checking for python2.7... python2.7
checking for virtualenv... no
checking for virtualenv3... no
checking for virtualenv2... virtualenv2
}}}

And this is properly set in `Makefile` as follows.

{{{
VIRTUALENV = virtualenv2
}}}

However, `make` ignores that setting and attempts to use `virtualenv` as shown below.

{{{
~/mediagoblin-0.8.0 $ make
rm -f ./bin/python
virtualenv --system-site-packages --python=python2.7 .
make: virtualenv: Command not found
}}}

This can be fixed by changing `Makefile.in` as follows.

{{{
diff --git a/Makefile.in b/Makefile.in
index 5530b9e..5964a82 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -121,7 +121,7 @@ i18n: $(maybe_venv_dep)
 ifneq ($(VIRTUALENV),no)
 ./bin/python:
        rm -f ./bin/python
-       virtualenv --system-site-packages --python=$(PYTHON) .
+       ${VIRTUALENV} --system-site-packages --python=$(PYTHON) .
        ./bin/python setup.py develop --upgrade
 
 virtualenv: bin/python extlib
}}}"	defect	closed	major	0.8.0	infrastructure	fixed	make,makefile,virtualenv