After submitting a form, our code needs to fetch the data from the form and put it to good use (update the db!).

Our current code uses:

  form = EditForm(request.form)
  if ... and form.validate():
    some_object.one_field = request.form.get('one_field')
    some_object_two_field = request.form['two_field']

This works mostly, but doesn't benefit from all the validation and cleanup that wtforms gives us. So this should be rewrittn to:

  form = EditForm(request.form)
  if ... and form.validate():
    some_object.one_field = form.one_field.data
    some_object_two_field = form.two_field.data

This can be done in small chunks on a file by file basis, or whatever fits someone wanting to work on this. No need to do all at once. Small changes are easier to review anyway.

Currently MediaGoblin only has the option of using plain SMTP or SMTP over SSL (which has deprecated for some time now). Using STARTTLS is completely unsupported.

These changes address this issue by attempting to use the STARTTLS command after EHLO/HELO. By default it will carry on as normal if STARTTLS command is unavailable, this can be changed by setting email_smtp_force_tls in the config.

Before this can be considered for merging there are two things that need to be taken care of:

• Unit test - I have no idea how to change email_smtp_force_tls at runtime, so I can't test this config option in both states.
• Documentation - I can't see where email_smtp_* are documented. In particular, settings email_smtp_use_ssl and email_smtp_force_tls might confuse users

Patches can be found on the "starttls" branch of this git repo: ​https://gitorious.org/mediagoblin/mediagoblin-starttls/commits/starttls

Perhaps we should use ​http://pfefferle.github.com/openwebicons/ for any icons in MediaGoblin, how does that sound?